From 26ce3dac2118614cd728c038e9a7bcfb80f3de2b Mon Sep 17 00:00:00 2001 From: Hari Babu Date: Thu, 29 Mar 2018 16:59:20 +1100 Subject: [PATCH 06/16] Tuple Insert API is added to table AM heap_insert, heap_delete, heap_fetch, heap_update, heap_get_latest_oid, heap_lock_tuple and heap_multi_insert functions are added to table AM. Move the index insertion logic into table AM, The Index insert still outside for the case of multi_insert (Yet to change). In case of delete also, the index tuple delete function pointer is avaiable. Replaced the usage of HeapTuple with storageTuple in some places, increased the use of slot. --- src/backend/access/common/heaptuple.c | 24 +++ src/backend/access/heap/heapam.c | 31 +-- src/backend/access/heap/heapam_handler.c | 285 ++++++++++++++++++++++++++++ src/backend/access/heap/heapam_visibility.c | 3 + src/backend/access/heap/rewriteheap.c | 5 +- src/backend/access/heap/tuptoaster.c | 9 +- src/backend/access/table/Makefile | 2 +- src/backend/access/table/tableam.c | 132 +++++++++++++ src/backend/commands/copy.c | 43 ++--- src/backend/commands/createas.c | 24 ++- src/backend/commands/matview.c | 22 ++- src/backend/commands/tablecmds.c | 6 +- src/backend/commands/trigger.c | 50 ++--- src/backend/executor/execIndexing.c | 2 +- src/backend/executor/execMain.c | 146 +++++++------- src/backend/executor/execReplication.c | 72 +++---- src/backend/executor/nodeLockRows.c | 47 +++-- src/backend/executor/nodeModifyTable.c | 229 ++++++++++------------ src/backend/executor/nodeTidscan.c | 23 +-- src/backend/utils/adt/tid.c | 5 +- src/include/access/heapam.h | 8 +- src/include/access/htup_details.h | 1 + src/include/access/tableam.h | 84 ++++++++ src/include/access/tableam_common.h | 3 - src/include/access/tableamapi.h | 74 +++++++- src/include/commands/trigger.h | 2 +- src/include/executor/executor.h | 15 +- src/include/executor/tuptable.h | 1 + src/include/nodes/execnodes.h | 8 +- 29 files changed, 973 insertions(+), 383 deletions(-) create mode 100644 src/backend/access/table/tableam.c create mode 100644 src/include/access/tableam.h diff --git a/src/backend/access/common/heaptuple.c b/src/backend/access/common/heaptuple.c index 25e48deaa1..166209ec55 100644 --- a/src/backend/access/common/heaptuple.c +++ b/src/backend/access/common/heaptuple.c @@ -1064,6 +1064,30 @@ heap_copy_tuple_as_datum(HeapTuple tuple, TupleDesc tupleDesc) return PointerGetDatum(td); } +/* + * heap_form_tuple_by_datum + * construct a tuple from the given dataum + * + * The result is allocated in the current memory context. + */ +HeapTuple +heap_form_tuple_by_datum(Datum data, Oid tableoid) +{ + HeapTuple newTuple; + HeapTupleHeader td; + + td = DatumGetHeapTupleHeader(data); + + newTuple = (HeapTuple) palloc(HEAPTUPLESIZE + HeapTupleHeaderGetDatumLength(td)); + newTuple->t_len = HeapTupleHeaderGetDatumLength(td); + newTuple->t_self = td->t_ctid; + newTuple->t_tableOid = tableoid; + newTuple->t_data = (HeapTupleHeader) ((char *) newTuple + HEAPTUPLESIZE); + memcpy((char *) newTuple->t_data, (char *) td, newTuple->t_len); + + return newTuple; +} + /* * heap_form_tuple * construct a tuple from the given values[] and isnull[] arrays, diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index ee407084c5..67b9b07337 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -1920,13 +1920,13 @@ heap_getnext(HeapScanDesc scan, ScanDirection direction) */ bool heap_fetch(Relation relation, + ItemPointer tid, Snapshot snapshot, HeapTuple tuple, Buffer *userbuf, bool keep_buf, Relation stats_relation) { - ItemPointer tid = &(tuple->t_self); ItemId lp; Buffer buffer; Page page; @@ -1960,7 +1960,6 @@ heap_fetch(Relation relation, ReleaseBuffer(buffer); *userbuf = InvalidBuffer; } - tuple->t_data = NULL; return false; } @@ -1982,13 +1981,13 @@ heap_fetch(Relation relation, ReleaseBuffer(buffer); *userbuf = InvalidBuffer; } - tuple->t_data = NULL; return false; } /* - * fill in *tuple fields + * fill in tuple fields and place it in stuple */ + ItemPointerCopy(tid, &(tuple->t_self)); tuple->t_data = (HeapTupleHeader) PageGetItem(page, lp); tuple->t_len = ItemIdGetLength(lp); tuple->t_tableOid = RelationGetRelid(relation); @@ -2340,7 +2339,6 @@ heap_get_latest_tid(Relation relation, } /* end of loop */ } - /* * UpdateXmaxHintBits - update tuple hint bits after xmax transaction ends * @@ -4747,7 +4745,7 @@ heap_lock_tuple(Relation relation, HeapTuple tuple, tuple->t_tableOid = RelationGetRelid(relation); l3: - result = relation->rd_tableamroutine->snapshot_satisfiesUpdate(tuple, cid, *buffer); + result = HeapTupleSatisfiesUpdate(tuple, cid, *buffer); if (result == HeapTupleInvisible) { @@ -5040,7 +5038,7 @@ l3: * or we must wait for the locking transaction or multixact; so below * we ensure that we grab buffer lock after the sleep. */ - if (require_sleep && result == HeapTupleUpdated) + if (require_sleep && (result == HeapTupleUpdated)) { LockBuffer(*buffer, BUFFER_LOCK_EXCLUSIVE); goto failed; @@ -5812,9 +5810,8 @@ heap_lock_updated_tuple_rec(Relation rel, ItemPointer tid, TransactionId xid, new_infomask = 0; new_xmax = InvalidTransactionId; block = ItemPointerGetBlockNumber(&tupid); - ItemPointerCopy(&tupid, &(mytup.t_self)); - if (!heap_fetch(rel, SnapshotAny, &mytup, &buf, false, NULL)) + if (!heap_fetch(rel, &tupid, SnapshotAny, &mytup, &buf, false, NULL)) { /* * if we fail to find the updated version of the tuple, it's @@ -6174,14 +6171,18 @@ heap_lock_updated_tuple(Relation rel, HeapTuple tuple, ItemPointer ctid, * An explicit confirmation WAL record also makes logical decoding simpler. */ void -heap_finish_speculative(Relation relation, HeapTuple tuple) +heap_finish_speculative(Relation relation, TupleTableSlot *slot) { + HeapamTuple *stuple = (HeapamTuple *) slot->tts_storage; + HeapTuple tuple = stuple->hst_heaptuple; Buffer buffer; Page page; OffsetNumber offnum; ItemId lp = NULL; HeapTupleHeader htup; + Assert(slot->tts_speculativeToken != 0); + buffer = ReadBuffer(relation, ItemPointerGetBlockNumber(&(tuple->t_self))); LockBuffer(buffer, BUFFER_LOCK_EXCLUSIVE); page = (Page) BufferGetPage(buffer); @@ -6236,6 +6237,7 @@ heap_finish_speculative(Relation relation, HeapTuple tuple) END_CRIT_SECTION(); UnlockReleaseBuffer(buffer); + slot->tts_speculativeToken = 0; } /* @@ -6265,8 +6267,10 @@ heap_finish_speculative(Relation relation, HeapTuple tuple) * confirmation records. */ void -heap_abort_speculative(Relation relation, HeapTuple tuple) +heap_abort_speculative(Relation relation, TupleTableSlot *slot) { + HeapamTuple *stuple = (HeapamTuple *) slot->tts_storage; + HeapTuple tuple = stuple->hst_heaptuple; TransactionId xid = GetCurrentTransactionId(); ItemPointer tid = &(tuple->t_self); ItemId lp; @@ -6275,6 +6279,10 @@ heap_abort_speculative(Relation relation, HeapTuple tuple) BlockNumber block; Buffer buffer; + /* + * Assert(slot->tts_speculativeToken != 0); This needs some update in + * toast + */ Assert(ItemPointerIsValid(tid)); block = ItemPointerGetBlockNumber(tid); @@ -6388,6 +6396,7 @@ heap_abort_speculative(Relation relation, HeapTuple tuple) /* count deletion, as we counted the insertion too */ pgstat_count_heap_delete(relation); + slot->tts_speculativeToken = 0; } /* diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c index 96daa6a5ef..006f604dbb 100644 --- a/src/backend/access/heap/heapam_handler.c +++ b/src/backend/access/heap/heapam_handler.c @@ -22,9 +22,282 @@ #include "access/heapam.h" #include "access/tableamapi.h" +#include "storage/lmgr.h" #include "utils/builtins.h" +#include "utils/rel.h" +#include "utils/tqual.h" +/* ---------------------------------------------------------------- + * storage AM support routines for heapam + * ---------------------------------------------------------------- + */ + +static bool +heapam_fetch(Relation relation, + ItemPointer tid, + Snapshot snapshot, + TableTuple * stuple, + Buffer *userbuf, + bool keep_buf, + Relation stats_relation) +{ + HeapTupleData tuple; + + *stuple = NULL; + if (heap_fetch(relation, tid, snapshot, &tuple, userbuf, keep_buf, stats_relation)) + { + *stuple = heap_copytuple(&tuple); + return true; + } + + return false; +} + +/* + * Insert a heap tuple from a slot, which may contain an OID and speculative + * insertion token. + */ +static Oid +heapam_heap_insert(Relation relation, TupleTableSlot *slot, CommandId cid, + int options, BulkInsertState bistate, InsertIndexTuples IndexFunc, + EState *estate, List *arbiterIndexes, List **recheckIndexes) +{ + Oid oid; + HeapTuple tuple = NULL; + + if (slot->tts_storage) + { + HeapamTuple *htuple = slot->tts_storage; + + tuple = htuple->hst_heaptuple; + + if (relation->rd_rel->relhasoids) + HeapTupleSetOid(tuple, InvalidOid); + } + else + { + /* + * Obtain the physical tuple to insert, building from the slot values. + * XXX: maybe the slot already contains a physical tuple in the right + * format? In fact, if the slot isn't fully deformed, this is + * completely bogus ... + */ + tuple = heap_form_tuple(slot->tts_tupleDescriptor, + slot->tts_values, + slot->tts_isnull); + } + + /* Set the OID, if the slot has one */ + if (slot->tts_tupleOid != InvalidOid) + HeapTupleHeaderSetOid(tuple->t_data, slot->tts_tupleOid); + + /* Update the tuple with table oid */ + if (slot->tts_tableOid != InvalidOid) + tuple->t_tableOid = slot->tts_tableOid; + + /* Set the speculative insertion token, if the slot has one */ + if ((options & HEAP_INSERT_SPECULATIVE) && slot->tts_speculativeToken) + HeapTupleHeaderSetSpeculativeToken(tuple->t_data, slot->tts_speculativeToken); + + /* Perform the insertion, and copy the resulting ItemPointer */ + oid = heap_insert(relation, tuple, cid, options, bistate); + ItemPointerCopy(&tuple->t_self, &slot->tts_tid); + + if (slot->tts_storage == NULL) + ExecStoreTuple(tuple, slot, InvalidBuffer, true); + + if ((estate != NULL) && (estate->es_result_relation_info->ri_NumIndices > 0)) + { + Assert(IndexFunc != NULL); + + if (options & HEAP_INSERT_SPECULATIVE) + { + bool specConflict = false; + + *recheckIndexes = (IndexFunc) (slot, estate, true, + &specConflict, + arbiterIndexes); + + /* adjust the tuple's state accordingly */ + if (!specConflict) + heap_finish_speculative(relation, slot); + else + { + heap_abort_speculative(relation, slot); + slot->tts_specConflict = true; + } + } + else + { + *recheckIndexes = (IndexFunc) (slot, estate, false, + NULL, arbiterIndexes); + } + } + + return oid; +} + +static HTSU_Result +heapam_heap_delete(Relation relation, ItemPointer tid, CommandId cid, + Snapshot crosscheck, bool wait, DeleteIndexTuples IndexFunc, + HeapUpdateFailureData *hufd, bool changingPart) +{ + /* + * Currently Deleting of index tuples are handled at vacuum, in case + * if the storage itself is cleaning the dead tuples by itself, it is + * the time to call the index tuple deletion also. + */ + return heap_delete(relation, tid, cid, crosscheck, wait, hufd, changingPart); +} + + +/* + * Locks tuple and fetches its newest version and TID. + * + * relation - table containing tuple + * *tid - TID of tuple to lock (rest of struct need not be valid) + * snapshot - snapshot indentifying required version (used for assert check only) + * *stuple - tuple to be returned + * cid - current command ID (used for visibility test, and stored into + * tuple's cmax if lock is successful) + * mode - indicates if shared or exclusive tuple lock is desired + * wait_policy - what to do if tuple lock is not available + * flags – indicating how do we handle updated tuples + * *hufd - filled in failure cases + * + * Function result may be: + * HeapTupleMayBeUpdated: lock was successfully acquired + * HeapTupleInvisible: lock failed because tuple was never visible to us + * HeapTupleSelfUpdated: lock failed because tuple updated by self + * HeapTupleUpdated: lock failed because tuple updated by other xact + * HeapTupleWouldBlock: lock couldn't be acquired and wait_policy is skip + * + * In the failure cases other than HeapTupleInvisible, the routine fills + * *hufd with the tuple's t_ctid, t_xmax (resolving a possible MultiXact, + * if necessary), and t_cmax (the last only for HeapTupleSelfUpdated, + * since we cannot obtain cmax from a combocid generated by another + * transaction). + * See comments for struct HeapUpdateFailureData for additional info. + */ +static HTSU_Result +heapam_lock_tuple(Relation relation, ItemPointer tid, TableTuple *stuple, + CommandId cid, LockTupleMode mode, + LockWaitPolicy wait_policy, bool follow_updates, Buffer *buffer, + HeapUpdateFailureData *hufd) +{ + HTSU_Result result; + HeapTupleData tuple; + + Assert(stuple != NULL); + *stuple = NULL; + + tuple.t_self = *tid; + result = heap_lock_tuple(relation, &tuple, cid, mode, wait_policy, follow_updates, buffer, hufd); + + *stuple = heap_copytuple(&tuple); + + return result; +} + + +static HTSU_Result +heapam_heap_update(Relation relation, ItemPointer otid, TupleTableSlot *slot, + EState *estate, CommandId cid, Snapshot crosscheck, + bool wait, HeapUpdateFailureData *hufd, LockTupleMode *lockmode, + InsertIndexTuples IndexFunc, List **recheckIndexes) +{ + HeapTuple tuple; + HTSU_Result result; + + if (slot->tts_storage) + { + HeapamTuple *htuple = slot->tts_storage; + + tuple = htuple->hst_heaptuple; + } + else + { + tuple = heap_form_tuple(slot->tts_tupleDescriptor, + slot->tts_values, + slot->tts_isnull); + } + + /* Set the OID, if the slot has one */ + if (slot->tts_tupleOid != InvalidOid) + HeapTupleHeaderSetOid(tuple->t_data, slot->tts_tupleOid); + + /* Update the tuple with table oid */ + if (slot->tts_tableOid != InvalidOid) + tuple->t_tableOid = slot->tts_tableOid; + + result = heap_update(relation, otid, tuple, cid, crosscheck, wait, + hufd, lockmode); + ItemPointerCopy(&tuple->t_self, &slot->tts_tid); + + if (slot->tts_storage == NULL) + ExecStoreTuple(tuple, slot, InvalidBuffer, true); + + /* + * Note: instead of having to update the old index tuples associated with + * the heap tuple, all we do is form and insert new index tuples. This is + * because UPDATEs are actually DELETEs and INSERTs, and index tuple + * deletion is done later by VACUUM (see notes in ExecDelete). All we do + * here is insert new index tuples. -cim 9/27/89 + */ + + /* + * insert index entries for tuple + * + * Note: heap_update returns the tid (location) of the new tuple in the + * t_self field. + * + * If it's a HOT update, we mustn't insert new index entries. + */ + if ((result == HeapTupleMayBeUpdated) && + ((estate != NULL) && (estate->es_result_relation_info->ri_NumIndices > 0)) && + (!HeapTupleIsHeapOnly(tuple))) + *recheckIndexes = (IndexFunc) (slot, estate, false, NULL, NIL); + + return result; +} + +static tuple_data +heapam_get_tuple_data(TableTuple tuple, tuple_data_flags flags) +{ + tuple_data result; + + switch (flags) + { + case XMIN: + result.xid = HeapTupleHeaderGetXmin(((HeapTuple) tuple)->t_data); + break; + case UPDATED_XID: + result.xid = HeapTupleHeaderGetUpdateXid(((HeapTuple) tuple)->t_data); + break; + case CMIN: + result.cid = HeapTupleHeaderGetCmin(((HeapTuple) tuple)->t_data); + break; + case TID: + result.tid = ((HeapTuple) tuple)->t_self; + break; + case CTID: + result.tid = ((HeapTuple) tuple)->t_data->t_ctid; + break; + default: + Assert(0); + break; + } + + return result; +} + +static TableTuple +heapam_form_tuple_by_datum(Datum data, Oid tableoid) +{ + return heap_form_tuple_by_datum(data, tableoid); +} + Datum heap_tableam_handler(PG_FUNCTION_ARGS) { @@ -37,5 +310,17 @@ heap_tableam_handler(PG_FUNCTION_ARGS) amroutine->slot_storageam = slot_tableam_handler; + amroutine->tuple_fetch = heapam_fetch; + amroutine->tuple_insert = heapam_heap_insert; + amroutine->tuple_delete = heapam_heap_delete; + amroutine->tuple_update = heapam_heap_update; + amroutine->tuple_lock = heapam_lock_tuple; + amroutine->multi_insert = heap_multi_insert; + + amroutine->get_tuple_data = heapam_get_tuple_data; + amroutine->tuple_from_datum = heapam_form_tuple_by_datum; + amroutine->tuple_get_latest_tid = heap_get_latest_tid; + amroutine->relation_sync = heap_sync; + PG_RETURN_POINTER(amroutine); } diff --git a/src/backend/access/heap/heapam_visibility.c b/src/backend/access/heap/heapam_visibility.c index c45575f049..9051d4be88 100644 --- a/src/backend/access/heap/heapam_visibility.c +++ b/src/backend/access/heap/heapam_visibility.c @@ -115,6 +115,9 @@ static inline void SetHintBits(HeapTupleHeader tuple, Buffer buffer, uint16 infomask, TransactionId xid) { + if (!BufferIsValid(buffer)) + return; + if (TransactionIdIsValid(xid)) { /* NB: xid must be known committed here! */ diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c index 8d3c861a33..de696a04b8 100644 --- a/src/backend/access/heap/rewriteheap.c +++ b/src/backend/access/heap/rewriteheap.c @@ -110,6 +110,7 @@ #include "access/heapam.h" #include "access/heapam_xlog.h" #include "access/rewriteheap.h" +#include "access/tableam.h" #include "access/transam.h" #include "access/tuptoaster.h" #include "access/xact.h" @@ -126,13 +127,13 @@ #include "storage/bufmgr.h" #include "storage/fd.h" +#include "storage/procarray.h" #include "storage/smgr.h" #include "utils/memutils.h" #include "utils/rel.h" #include "utils/tqual.h" -#include "storage/procarray.h" /* * State associated with a rewrite operation. This is opaque to the user @@ -357,7 +358,7 @@ end_heap_rewrite(RewriteState state) * wrote before the checkpoint. */ if (RelationNeedsWAL(state->rs_new_rel)) - heap_sync(state->rs_new_rel); + table_sync(state->rs_new_rel); logical_end_heap_rewrite(state); diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c index cd42c50b09..7c427dce8a 100644 --- a/src/backend/access/heap/tuptoaster.c +++ b/src/backend/access/heap/tuptoaster.c @@ -32,6 +32,7 @@ #include "access/genam.h" #include "access/heapam.h" +#include "access/tableam.h" #include "access/tuptoaster.h" #include "access/xact.h" #include "catalog/catalog.h" @@ -1777,7 +1778,13 @@ toast_delete_datum(Relation rel, Datum value, bool is_speculative) * Have a chunk, delete it */ if (is_speculative) - heap_abort_speculative(toastrel, toasttup); + { + TupleTableSlot *slot = MakeSingleTupleTableSlot(RelationGetDescr(toastrel)); + + ExecStoreTuple(toasttup, slot, InvalidBuffer, false); + heap_abort_speculative(toastrel, slot); + ExecDropSingleTupleTableSlot(slot); + } else simple_heap_delete(toastrel, &toasttup->t_self); } diff --git a/src/backend/access/table/Makefile b/src/backend/access/table/Makefile index ff0989ed24..fe22bf9208 100644 --- a/src/backend/access/table/Makefile +++ b/src/backend/access/table/Makefile @@ -12,6 +12,6 @@ subdir = src/backend/access/table top_builddir = ../../../.. include $(top_builddir)/src/Makefile.global -OBJS = tableamapi.o tableam_common.o +OBJS = tableam.o tableamapi.o tableam_common.o include $(top_srcdir)/src/backend/common.mk diff --git a/src/backend/access/table/tableam.c b/src/backend/access/table/tableam.c new file mode 100644 index 0000000000..af4e53b76e --- /dev/null +++ b/src/backend/access/table/tableam.c @@ -0,0 +1,132 @@ +/*------------------------------------------------------------------------- + * + * tableam.c + * table access method code + * + * Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group + * Portions Copyright (c) 1994, Regents of the University of California + * + * + * IDENTIFICATION + * src/backend/access/table/tableam.c + * + *------------------------------------------------------------------------- + */ +#include "postgres.h" + +#include "access/tableam.h" +#include "access/tableamapi.h" +#include "utils/rel.h" + +/* + * table_fetch - retrieve tuple with given tid + */ +bool +table_fetch(Relation relation, + ItemPointer tid, + Snapshot snapshot, + TableTuple * stuple, + Buffer *userbuf, + bool keep_buf, + Relation stats_relation) +{ + return relation->rd_tableamroutine->tuple_fetch(relation, tid, snapshot, stuple, + userbuf, keep_buf, stats_relation); +} + + +/* + * table_lock_tuple - lock a tuple in shared or exclusive mode + */ +HTSU_Result +table_lock_tuple(Relation relation, ItemPointer tid, TableTuple * stuple, + CommandId cid, LockTupleMode mode, LockWaitPolicy wait_policy, + bool follow_updates, Buffer *buffer, HeapUpdateFailureData *hufd) +{ + return relation->rd_tableamroutine->tuple_lock(relation, tid, stuple, + cid, mode, wait_policy, + follow_updates, buffer, hufd); +} + +/* + * Insert a tuple from a slot into table AM routine + */ +Oid +table_insert(Relation relation, TupleTableSlot *slot, CommandId cid, + int options, BulkInsertState bistate, InsertIndexTuples IndexFunc, + EState *estate, List *arbiterIndexes, List **recheckIndexes) +{ + return relation->rd_tableamroutine->tuple_insert(relation, slot, cid, options, + bistate, IndexFunc, estate, + arbiterIndexes, recheckIndexes); +} + +/* + * Delete a tuple from tid using table AM routine + */ +HTSU_Result +table_delete(Relation relation, ItemPointer tid, CommandId cid, + Snapshot crosscheck, bool wait, DeleteIndexTuples IndexFunc, + HeapUpdateFailureData *hufd, bool changingPart) +{ + return relation->rd_tableamroutine->tuple_delete(relation, tid, cid, + crosscheck, wait, IndexFunc, hufd, changingPart); +} + +/* + * update a tuple from tid using table AM routine + */ +HTSU_Result +table_update(Relation relation, ItemPointer otid, TupleTableSlot *slot, + EState *estate, CommandId cid, Snapshot crosscheck, bool wait, + HeapUpdateFailureData *hufd, LockTupleMode *lockmode, + InsertIndexTuples IndexFunc, List **recheckIndexes) +{ + return relation->rd_tableamroutine->tuple_update(relation, otid, slot, estate, + cid, crosscheck, wait, hufd, + lockmode, IndexFunc, recheckIndexes); +} + + +/* + * table_multi_insert - insert multiple tuple into a table + */ +void +table_multi_insert(Relation relation, HeapTuple *tuples, int ntuples, + CommandId cid, int options, BulkInsertState bistate) +{ + relation->rd_tableamroutine->multi_insert(relation, tuples, ntuples, + cid, options, bistate); +} + +tuple_data +table_tuple_get_data(Relation relation, TableTuple tuple, tuple_data_flags flags) +{ + return relation->rd_tableamroutine->get_tuple_data(tuple, flags); +} + +TableTuple +table_tuple_by_datum(Relation relation, Datum data, Oid tableoid) +{ + if (relation) + return relation->rd_tableamroutine->tuple_from_datum(data, tableoid); + else + return heap_form_tuple_by_datum(data, tableoid); +} + +void +table_get_latest_tid(Relation relation, + Snapshot snapshot, + ItemPointer tid) +{ + relation->rd_tableamroutine->tuple_get_latest_tid(relation, snapshot, tid); +} + +/* + * table_sync - sync a heap, for use when no WAL has been written + */ +void +table_sync(Relation rel) +{ + rel->rd_tableamroutine->relation_sync(rel); +} diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 72de5274f2..020b857d74 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -20,6 +20,7 @@ #include "access/heapam.h" #include "access/htup_details.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "access/xact.h" #include "access/xlog.h" @@ -2711,8 +2712,6 @@ CopyFrom(CopyState cstate) if (slot == NULL) /* "do nothing" */ skip_tuple = true; - else /* trigger might have changed tuple */ - tuple = ExecHeapifySlot(slot); } if (!skip_tuple) @@ -2796,20 +2795,14 @@ CopyFrom(CopyState cstate) tuple->t_tableOid = RelationGetRelid(resultRelInfo->ri_RelationDesc); } else - heap_insert(resultRelInfo->ri_RelationDesc, tuple, - mycid, hi_options, bistate); - - /* And create index entries for it */ - if (resultRelInfo->ri_NumIndices > 0) - recheckIndexes = ExecInsertIndexTuples(slot, - &(tuple->t_self), - estate, - false, - NULL, - NIL); + { + /* OK, store the tuple and create index entries for it */ + table_insert(resultRelInfo->ri_RelationDesc, slot, mycid, hi_options, + bistate, ExecInsertIndexTuples, estate, NIL, &recheckIndexes); + } /* AFTER ROW INSERT Triggers */ - ExecARInsertTriggers(estate, resultRelInfo, tuple, + ExecARInsertTriggers(estate, resultRelInfo, slot, recheckIndexes, cstate->transition_capture); list_free(recheckIndexes); @@ -2887,7 +2880,7 @@ next_tuple: * indexes since those use WAL anyway) */ if (hi_options & HEAP_INSERT_SKIP_WAL) - heap_sync(cstate->rel); + table_sync(cstate->rel); return processed; } @@ -2920,12 +2913,12 @@ CopyFromInsertBatch(CopyState cstate, EState *estate, CommandId mycid, * before calling it. */ oldcontext = MemoryContextSwitchTo(GetPerTupleMemoryContext(estate)); - heap_multi_insert(cstate->rel, - bufferedTuples, - nBufferedTuples, - mycid, - hi_options, - bistate); + table_multi_insert(cstate->rel, + bufferedTuples, + nBufferedTuples, + mycid, + hi_options, + bistate); MemoryContextSwitchTo(oldcontext); /* @@ -2941,10 +2934,9 @@ CopyFromInsertBatch(CopyState cstate, EState *estate, CommandId mycid, cstate->cur_lineno = firstBufferedLineNo + i; ExecStoreTuple(bufferedTuples[i], myslot, InvalidBuffer, false); recheckIndexes = - ExecInsertIndexTuples(myslot, &(bufferedTuples[i]->t_self), - estate, false, NULL, NIL); + ExecInsertIndexTuples(myslot, estate, false, NULL, NIL); ExecARInsertTriggers(estate, resultRelInfo, - bufferedTuples[i], + myslot, recheckIndexes, cstate->transition_capture); list_free(recheckIndexes); } @@ -2961,8 +2953,9 @@ CopyFromInsertBatch(CopyState cstate, EState *estate, CommandId mycid, for (i = 0; i < nBufferedTuples; i++) { cstate->cur_lineno = firstBufferedLineNo + i; + ExecStoreTuple(bufferedTuples[i], myslot, InvalidBuffer, false); ExecARInsertTriggers(estate, resultRelInfo, - bufferedTuples[i], + myslot, NIL, cstate->transition_capture); } } diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c index ff2b7b75e9..9c531b7f28 100644 --- a/src/backend/commands/createas.c +++ b/src/backend/commands/createas.c @@ -26,6 +26,7 @@ #include "access/reloptions.h" #include "access/htup_details.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "access/xact.h" #include "access/xlog.h" @@ -582,25 +583,28 @@ static bool intorel_receive(TupleTableSlot *slot, DestReceiver *self) { DR_intorel *myState = (DR_intorel *) self; - HeapTuple tuple; /* * get the heap tuple out of the tuple table slot, making sure we have a * writable copy */ - tuple = ExecHeapifySlot(slot); + ExecMaterializeSlot(slot); /* * force assignment of new OID (see comments in ExecInsert) */ if (myState->rel->rd_rel->relhasoids) - HeapTupleSetOid(tuple, InvalidOid); - - heap_insert(myState->rel, - tuple, - myState->output_cid, - myState->hi_options, - myState->bistate); + slot->tts_tupleOid = InvalidOid; + + table_insert(myState->rel, + slot, + myState->output_cid, + myState->hi_options, + myState->bistate, + NULL, + NULL, + NIL, + NULL); /* We know this is a newly created relation, so there are no indexes */ @@ -619,7 +623,7 @@ intorel_shutdown(DestReceiver *self) /* If we skipped using WAL, must heap_sync before commit */ if (myState->hi_options & HEAP_INSERT_SKIP_WAL) - heap_sync(myState->rel); + table_sync(myState->rel); /* close rel, but keep lock until commit */ heap_close(myState->rel, NoLock); diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c index 1359455579..b156f27259 100644 --- a/src/backend/commands/matview.c +++ b/src/backend/commands/matview.c @@ -16,6 +16,7 @@ #include "access/htup_details.h" #include "access/multixact.h" +#include "access/tableam.h" #include "access/xact.h" #include "access/xlog.h" #include "catalog/catalog.h" @@ -478,19 +479,22 @@ static bool transientrel_receive(TupleTableSlot *slot, DestReceiver *self) { DR_transientrel *myState = (DR_transientrel *) self; - HeapTuple tuple; /* * get the heap tuple out of the tuple table slot, making sure we have a * writable copy */ - tuple = ExecHeapifySlot(slot); - - heap_insert(myState->transientrel, - tuple, - myState->output_cid, - myState->hi_options, - myState->bistate); + ExecMaterializeSlot(slot); + + table_insert(myState->transientrel, + slot, + myState->output_cid, + myState->hi_options, + myState->bistate, + NULL, + NULL, + NIL, + NULL); /* We know this is a newly created relation, so there are no indexes */ @@ -509,7 +513,7 @@ transientrel_shutdown(DestReceiver *self) /* If we skipped using WAL, must heap_sync before commit */ if (myState->hi_options & HEAP_INSERT_SKIP_WAL) - heap_sync(myState->transientrel); + table_sync(myState->transientrel); /* close transientrel, but keep lock until commit */ heap_close(myState->transientrel, NoLock); diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 8b848f91a7..f3bae024b1 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -20,6 +20,7 @@ #include "access/multixact.h" #include "access/reloptions.h" #include "access/relscan.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "access/tupconvert.h" #include "access/xact.h" @@ -4825,7 +4826,8 @@ ATRewriteTable(AlteredTableInfo *tab, Oid OIDNewHeap, LOCKMODE lockmode) /* Write the tuple out to the new relation */ if (newrel) - heap_insert(newrel, tuple, mycid, hi_options, bistate); + table_insert(newrel, newslot, mycid, hi_options, bistate, + NULL, NULL, NIL, NULL); ResetExprContext(econtext); @@ -4849,7 +4851,7 @@ ATRewriteTable(AlteredTableInfo *tab, Oid OIDNewHeap, LOCKMODE lockmode) /* If we skipped writing WAL, then we need to sync the heap. */ if (hi_options & HEAP_INSERT_SKIP_WAL) - heap_sync(newrel); + table_sync(newrel); heap_close(newrel, NoLock); } diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index f46fd0a935..a4ea981442 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -15,6 +15,7 @@ #include "access/genam.h" #include "access/heapam.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "access/htup_details.h" #include "access/xact.h" @@ -2579,17 +2580,21 @@ ExecBRInsertTriggers(EState *estate, ResultRelInfo *relinfo, void ExecARInsertTriggers(EState *estate, ResultRelInfo *relinfo, - HeapTuple trigtuple, List *recheckIndexes, + TupleTableSlot *slot, List *recheckIndexes, TransitionCaptureState *transition_capture) { TriggerDesc *trigdesc = relinfo->ri_TrigDesc; if ((trigdesc && trigdesc->trig_insert_after_row) || (transition_capture && transition_capture->tcs_insert_new_table)) + { + HeapTuple trigtuple = ExecHeapifySlot(slot); + AfterTriggerSaveEvent(estate, relinfo, TRIGGER_EVENT_INSERT, true, NULL, trigtuple, recheckIndexes, NULL, transition_capture); + } } TupleTableSlot * @@ -3244,9 +3249,10 @@ GetTupleForTrigger(EState *estate, TupleTableSlot **newSlot) { Relation relation = relinfo->ri_RelationDesc; - HeapTupleData tuple; + TableTuple tuple; HeapTuple result; Buffer buffer; + tuple_data t_data; if (newSlot != NULL) { @@ -3262,11 +3268,11 @@ GetTupleForTrigger(EState *estate, * lock tuple for update */ ltrmark:; - tuple.t_self = *tid; - test = heap_lock_tuple(relation, &tuple, - estate->es_output_cid, - lockmode, LockWaitBlock, - false, &buffer, &hufd); + test = table_lock_tuple(relation, tid, &tuple, + estate->es_output_cid, + lockmode, LockWaitBlock, + false, &buffer, &hufd); + result = tuple; switch (test) { case HeapTupleSelfUpdated: @@ -3303,7 +3309,8 @@ ltrmark:; (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE), errmsg("tuple to be locked was already moved to another partition due to concurrent update"))); - if (!ItemPointerEquals(&hufd.ctid, &tuple.t_self)) + t_data = relation->rd_tableamroutine->get_tuple_data(tuple, TID); + if (!ItemPointerEquals(&hufd.ctid, &(t_data.tid))) { /* it was updated, so look at the updated version */ TupleTableSlot *epqslot; @@ -3350,6 +3357,7 @@ ltrmark:; { Page page; ItemId lp; + HeapTupleData tupledata; buffer = ReadBuffer(relation, ItemPointerGetBlockNumber(tid)); @@ -3368,17 +3376,17 @@ ltrmark:; Assert(ItemIdIsNormal(lp)); - tuple.t_data = (HeapTupleHeader) PageGetItem(page, lp); - tuple.t_len = ItemIdGetLength(lp); - tuple.t_self = *tid; - tuple.t_tableOid = RelationGetRelid(relation); + tupledata.t_data = (HeapTupleHeader) PageGetItem(page, lp); + tupledata.t_len = ItemIdGetLength(lp); + tupledata.t_self = *tid; + tupledata.t_tableOid = RelationGetRelid(relation); LockBuffer(buffer, BUFFER_LOCK_UNLOCK); + + result = heap_copytuple(&tupledata); } - result = heap_copytuple(&tuple); ReleaseBuffer(buffer); - return result; } @@ -4186,8 +4194,8 @@ AfterTriggerExecute(AfterTriggerEvent event, AfterTriggerShared evtshared = GetTriggerSharedData(event); Oid tgoid = evtshared->ats_tgoid; TriggerData LocTriggerData; - HeapTupleData tuple1; - HeapTupleData tuple2; + TableTuple tuple1; + TableTuple tuple2; HeapTuple rettuple; Buffer buffer1 = InvalidBuffer; Buffer buffer2 = InvalidBuffer; @@ -4260,10 +4268,9 @@ AfterTriggerExecute(AfterTriggerEvent event, default: if (ItemPointerIsValid(&(event->ate_ctid1))) { - ItemPointerCopy(&(event->ate_ctid1), &(tuple1.t_self)); - if (!heap_fetch(rel, SnapshotAny, &tuple1, &buffer1, false, NULL)) + if (!table_fetch(rel, &(event->ate_ctid1), SnapshotAny, &tuple1, &buffer1, false, NULL)) elog(ERROR, "failed to fetch tuple1 for AFTER trigger"); - LocTriggerData.tg_trigtuple = &tuple1; + LocTriggerData.tg_trigtuple = tuple1; LocTriggerData.tg_trigtuplebuf = buffer1; } else @@ -4277,10 +4284,9 @@ AfterTriggerExecute(AfterTriggerEvent event, AFTER_TRIGGER_2CTID && ItemPointerIsValid(&(event->ate_ctid2))) { - ItemPointerCopy(&(event->ate_ctid2), &(tuple2.t_self)); - if (!heap_fetch(rel, SnapshotAny, &tuple2, &buffer2, false, NULL)) + if (!table_fetch(rel, &(event->ate_ctid2), SnapshotAny, &tuple2, &buffer2, false, NULL)) elog(ERROR, "failed to fetch tuple2 for AFTER trigger"); - LocTriggerData.tg_newtuple = &tuple2; + LocTriggerData.tg_newtuple = tuple2; LocTriggerData.tg_newtuplebuf = buffer2; } else diff --git a/src/backend/executor/execIndexing.c b/src/backend/executor/execIndexing.c index 903076ee3c..486d6986eb 100644 --- a/src/backend/executor/execIndexing.c +++ b/src/backend/executor/execIndexing.c @@ -269,12 +269,12 @@ ExecCloseIndices(ResultRelInfo *resultRelInfo) */ List * ExecInsertIndexTuples(TupleTableSlot *slot, - ItemPointer tupleid, EState *estate, bool noDupErr, bool *specConflict, List *arbiterIndexes) { + ItemPointer tupleid = &slot->tts_tid; List *result = NIL; ResultRelInfo *resultRelInfo; int i; diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 969944cc12..c677e4b19a 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -38,6 +38,7 @@ #include "postgres.h" #include "access/htup_details.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "access/transam.h" #include "access/xact.h" @@ -1924,7 +1925,7 @@ ExecPartitionCheckEmitError(ResultRelInfo *resultRelInfo, */ if (resultRelInfo->ri_PartitionRoot) { - HeapTuple tuple = ExecFetchSlotTuple(slot); + TableTuple tuple = ExecFetchSlotTuple(slot); TupleDesc old_tupdesc = RelationGetDescr(rel); TupleConversionMap *map; @@ -2004,7 +2005,7 @@ ExecConstraints(ResultRelInfo *resultRelInfo, */ if (resultRelInfo->ri_PartitionRoot) { - HeapTuple tuple = ExecFetchSlotTuple(slot); + TableTuple tuple = ExecFetchSlotTuple(slot); TupleConversionMap *map; rel = resultRelInfo->ri_PartitionRoot; @@ -2051,7 +2052,7 @@ ExecConstraints(ResultRelInfo *resultRelInfo, /* See the comment above. */ if (resultRelInfo->ri_PartitionRoot) { - HeapTuple tuple = ExecFetchSlotTuple(slot); + TableTuple tuple = ExecFetchSlotTuple(slot); TupleDesc old_tupdesc = RelationGetDescr(rel); TupleConversionMap *map; @@ -2506,7 +2507,8 @@ EvalPlanQual(EState *estate, EPQState *epqstate, ItemPointer tid, TransactionId priorXmax) { TupleTableSlot *slot; - HeapTuple copyTuple; + TableTuple copyTuple; + tuple_data t_data; Assert(rti > 0); @@ -2523,7 +2525,9 @@ EvalPlanQual(EState *estate, EPQState *epqstate, * For UPDATE/DELETE we have to return tid of actual row we're executing * PQ for. */ - *tid = copyTuple->t_self; + + t_data = table_tuple_get_data(relation, copyTuple, TID); + *tid = t_data.tid; /* * Need to run a recheck subquery. Initialize or reinitialize EPQ state. @@ -2554,7 +2558,7 @@ EvalPlanQual(EState *estate, EPQState *epqstate, * is to guard against early re-use of the EPQ query. */ if (!TupIsNull(slot)) - (void) ExecMaterializeSlot(slot); + ExecMaterializeSlot(slot); /* * Clear out the test tuple. This is needed in case the EPQ query is @@ -2587,14 +2591,14 @@ EvalPlanQual(EState *estate, EPQState *epqstate, * Note: properly, lockmode should be declared as enum LockTupleMode, * but we use "int" to avoid having to include heapam.h in executor.h. */ -HeapTuple +TableTuple EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, LockWaitPolicy wait_policy, ItemPointer tid, TransactionId priorXmax) { - HeapTuple copyTuple = NULL; - HeapTupleData tuple; + TableTuple tuple = NULL; SnapshotData SnapshotDirty; + tuple_data t_data; /* * fetch target tuple @@ -2602,12 +2606,12 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, * Loop here to deal with updated or busy tuples */ InitDirtySnapshot(SnapshotDirty); - tuple.t_self = *tid; for (;;) { Buffer buffer; + ItemPointerData ctid; - if (heap_fetch(relation, &SnapshotDirty, &tuple, &buffer, true, NULL)) + if (table_fetch(relation, tid, &SnapshotDirty, &tuple, &buffer, true, NULL)) { HTSU_Result test; HeapUpdateFailureData hufd; @@ -2621,7 +2625,7 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, * atomic, and Xmin never changes in an existing tuple, except to * invalid or frozen, and neither of those can match priorXmax.) */ - if (!TransactionIdEquals(HeapTupleHeaderGetXmin(tuple.t_data), + if (!TransactionIdEquals(HeapTupleHeaderGetXmin(((HeapTuple) tuple)->t_data), priorXmax)) { ReleaseBuffer(buffer); @@ -2643,7 +2647,8 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, { case LockWaitBlock: XactLockTableWait(SnapshotDirty.xmax, - relation, &tuple.t_self, + relation, + tid, XLTW_FetchUpdated); break; case LockWaitSkip: @@ -2672,20 +2677,23 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, * that priorXmax == xmin, so we can test that variable instead of * doing HeapTupleHeaderGetXmin again. */ - if (TransactionIdIsCurrentTransactionId(priorXmax) && - HeapTupleHeaderGetCmin(tuple.t_data) >= estate->es_output_cid) + if (TransactionIdIsCurrentTransactionId(priorXmax)) { - ReleaseBuffer(buffer); - return NULL; + t_data = table_tuple_get_data(relation, tuple, CMIN); + if (t_data.cid >= estate->es_output_cid) + { + ReleaseBuffer(buffer); + return NULL; + } } /* * This is a live tuple, so now try to lock it. */ - test = heap_lock_tuple(relation, &tuple, - estate->es_output_cid, - lockmode, wait_policy, - false, &buffer, &hufd); + test = table_lock_tuple(relation, tid, &tuple, + estate->es_output_cid, + lockmode, wait_policy, + false, &buffer, &hufd); /* We now have two pins on the buffer, get rid of one */ ReleaseBuffer(buffer); @@ -2725,12 +2733,15 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE), errmsg("tuple to be locked was already moved to another partition due to concurrent update"))); +#if 0 //hari /* Should not encounter speculative tuple on recheck */ Assert(!HeapTupleHeaderIsSpeculative(tuple.t_data)); - if (!ItemPointerEquals(&hufd.ctid, &tuple.t_self)) +#endif + t_data = table_tuple_get_data(relation, tuple, TID); + if (!ItemPointerEquals(&hufd.ctid, &t_data.tid)) { /* it was updated, so look at the updated version */ - tuple.t_self = hufd.ctid; + *tid = hufd.ctid; /* updated row should have xmin matching this xmax */ priorXmax = hufd.xmax; continue; @@ -2753,10 +2764,6 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, return NULL; /* keep compiler quiet */ } - /* - * We got tuple - now copy it for use by recheck query. - */ - copyTuple = heap_copytuple(&tuple); ReleaseBuffer(buffer); break; } @@ -2765,7 +2772,7 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, * If the referenced slot was actually empty, the latest version of * the row must have been deleted, so we need do nothing. */ - if (tuple.t_data == NULL) + if (tuple == NULL) { ReleaseBuffer(buffer); return NULL; @@ -2774,7 +2781,7 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, /* * As above, if xmin isn't what we're expecting, do nothing. */ - if (!TransactionIdEquals(HeapTupleHeaderGetXmin(tuple.t_data), + if (!TransactionIdEquals(HeapTupleHeaderGetXmin(((HeapTuple) tuple)->t_data), priorXmax)) { ReleaseBuffer(buffer); @@ -2795,13 +2802,17 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, */ /* check whether next version would be in a different partition */ - if (HeapTupleHeaderIndicatesMovedPartitions(tuple.t_data)) + /* hari: FIXME: use a new table API */ + if (HeapTupleHeaderIndicatesMovedPartitions(((HeapTuple) tuple)->t_data)) ereport(ERROR, (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE), errmsg("tuple to be locked was already moved to another partition due to concurrent update"))); + t_data = table_tuple_get_data(relation, tuple, CTID); + ctid = t_data.tid; + /* check whether tuple has been deleted */ - if (ItemPointerEquals(&tuple.t_self, &tuple.t_data->t_ctid)) + if (ItemPointerEquals(tid, &ctid)) { /* deleted, so forget about it */ ReleaseBuffer(buffer); @@ -2809,17 +2820,19 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode, } /* updated, so look at the updated row */ - tuple.t_self = tuple.t_data->t_ctid; + *tid = ctid; + /* updated row should have xmin matching this xmax */ - priorXmax = HeapTupleHeaderGetUpdateXid(tuple.t_data); + t_data = table_tuple_get_data(relation, tuple, UPDATED_XID); + priorXmax = t_data.xid; ReleaseBuffer(buffer); /* loop back to fetch next in chain */ } /* - * Return the copied tuple + * Return the tuple */ - return copyTuple; + return tuple; } /* @@ -2865,7 +2878,7 @@ EvalPlanQualSetPlan(EPQState *epqstate, Plan *subplan, List *auxrowmarks) * NB: passed tuple must be palloc'd; it may get freed later */ void -EvalPlanQualSetTuple(EPQState *epqstate, Index rti, HeapTuple tuple) +EvalPlanQualSetTuple(EPQState *epqstate, Index rti, TableTuple tuple) { EState *estate = epqstate->estate; @@ -2884,7 +2897,7 @@ EvalPlanQualSetTuple(EPQState *epqstate, Index rti, HeapTuple tuple) /* * Fetch back the current test tuple (if any) for the specified RTI */ -HeapTuple +TableTuple EvalPlanQualGetTuple(EPQState *epqstate, Index rti) { EState *estate = epqstate->estate; @@ -2912,7 +2925,7 @@ EvalPlanQualFetchRowMarks(EPQState *epqstate) ExecRowMark *erm = aerm->rowmark; Datum datum; bool isNull; - HeapTupleData tuple; + TableTuple tuple; if (RowMarkRequiresRowShareLock(erm->markType)) elog(ERROR, "EvalPlanQual doesn't support locking rowmarks"); @@ -2943,8 +2956,6 @@ EvalPlanQualFetchRowMarks(EPQState *epqstate) if (erm->markType == ROW_MARK_REFERENCE) { - HeapTuple copyTuple; - Assert(erm->relation != NULL); /* fetch the tuple's ctid */ @@ -2968,11 +2979,11 @@ EvalPlanQualFetchRowMarks(EPQState *epqstate) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot lock rows in foreign table \"%s\"", RelationGetRelationName(erm->relation)))); - copyTuple = fdwroutine->RefetchForeignRow(epqstate->estate, - erm, - datum, - &updated); - if (copyTuple == NULL) + tuple = fdwroutine->RefetchForeignRow(epqstate->estate, + erm, + datum, + &updated); + if (tuple == NULL) elog(ERROR, "failed to fetch tuple for EvalPlanQual recheck"); /* @@ -2986,32 +2997,28 @@ EvalPlanQualFetchRowMarks(EPQState *epqstate) /* ordinary table, fetch the tuple */ Buffer buffer; - tuple.t_self = *((ItemPointer) DatumGetPointer(datum)); - if (!heap_fetch(erm->relation, SnapshotAny, &tuple, &buffer, - false, NULL)) + if (!table_fetch(erm->relation, (ItemPointer) DatumGetPointer(datum), SnapshotAny, &tuple, &buffer, + false, NULL)) elog(ERROR, "failed to fetch tuple for EvalPlanQual recheck"); - if (HeapTupleHeaderGetNatts(tuple.t_data) < + if (HeapTupleHeaderGetNatts(((HeapTuple)tuple)->t_data) < RelationGetDescr(erm->relation)->natts) { - copyTuple = heap_expand_tuple(&tuple, + TableTuple copyTuple = tuple; + + tuple = heap_expand_tuple(copyTuple, RelationGetDescr(erm->relation)); + heap_freetuple(copyTuple); } - else - { - /* successful, copy tuple */ - copyTuple = heap_copytuple(&tuple); - } + ReleaseBuffer(buffer); } /* store tuple */ - EvalPlanQualSetTuple(epqstate, erm->rti, copyTuple); + EvalPlanQualSetTuple(epqstate, erm->rti, tuple); } else { - HeapTupleHeader td; - Assert(erm->markType == ROW_MARK_COPY); /* fetch the whole-row Var for the relation */ @@ -3021,19 +3028,12 @@ EvalPlanQualFetchRowMarks(EPQState *epqstate) /* non-locked rels could be on the inside of outer joins */ if (isNull) continue; - td = DatumGetHeapTupleHeader(datum); - - /* build a temporary HeapTuple control structure */ - tuple.t_len = HeapTupleHeaderGetDatumLength(td); - tuple.t_data = td; - /* relation might be a foreign table, if so provide tableoid */ - tuple.t_tableOid = erm->relid; - /* also copy t_ctid in case there's valid data there */ - tuple.t_self = td->t_ctid; - - /* copy and store tuple */ - EvalPlanQualSetTuple(epqstate, erm->rti, - heap_copytuple(&tuple)); + + tuple = table_tuple_by_datum(erm->relation, datum, erm->relid); + + /* store tuple */ + EvalPlanQualSetTuple(epqstate, erm->rti, tuple); + } } } @@ -3202,8 +3202,8 @@ EvalPlanQualStart(EPQState *epqstate, EState *parentestate, Plan *planTree) } else { - estate->es_epqTuple = (HeapTuple *) - palloc0(rtsize * sizeof(HeapTuple)); + estate->es_epqTuple = (TableTuple *) + palloc0(rtsize * sizeof(TableTuple)); estate->es_epqTupleSet = (bool *) palloc0(rtsize * sizeof(bool)); } diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c index ec42cf7801..53410c4cbf 100644 --- a/src/backend/executor/execReplication.c +++ b/src/backend/executor/execReplication.c @@ -15,6 +15,7 @@ #include "postgres.h" #include "access/relscan.h" +#include "access/tableam.h" #include "access/transam.h" #include "access/xact.h" #include "commands/trigger.h" @@ -169,19 +170,19 @@ retry: Buffer buf; HeapUpdateFailureData hufd; HTSU_Result res; - HeapTupleData locktup; - - ItemPointerCopy(&outslot->tts_tid, &locktup.t_self); + TableTuple locktup; PushActiveSnapshot(GetLatestSnapshot()); - res = heap_lock_tuple(rel, &locktup, GetCurrentCommandId(false), - lockmode, - LockWaitBlock, - false /* don't follow updates */ , - &buf, &hufd); + res = table_lock_tuple(rel, &(outslot->tts_tid), &locktup, GetCurrentCommandId(false), + lockmode, + LockWaitBlock, + false /* don't follow updates */ , + &buf, &hufd); /* the tuple slot already has the buffer pinned */ - ReleaseBuffer(buf); + if (BufferIsValid(buf)) + ReleaseBuffer(buf); + pfree(locktup); PopActiveSnapshot(); @@ -283,19 +284,20 @@ retry: Buffer buf; HeapUpdateFailureData hufd; HTSU_Result res; - HeapTupleData locktup; - - ItemPointerCopy(&outslot->tts_tid, &locktup.t_self); + TableTuple locktup; PushActiveSnapshot(GetLatestSnapshot()); - res = heap_lock_tuple(rel, &locktup, GetCurrentCommandId(false), - lockmode, - LockWaitBlock, - false /* don't follow updates */ , - &buf, &hufd); + res = table_lock_tuple(rel, &(outslot->tts_tid), &locktup, GetCurrentCommandId(false), + lockmode, + LockWaitBlock, + false /* don't follow updates */ , + &buf, &hufd); /* the tuple slot already has the buffer pinned */ - ReleaseBuffer(buf); + if (BufferIsValid(buf)) + ReleaseBuffer(buf); + + pfree(locktup); PopActiveSnapshot(); @@ -339,7 +341,6 @@ void ExecSimpleRelationInsert(EState *estate, TupleTableSlot *slot) { bool skip_tuple = false; - HeapTuple tuple; ResultRelInfo *resultRelInfo = estate->es_result_relation_info; Relation rel = resultRelInfo->ri_RelationDesc; @@ -368,19 +369,12 @@ ExecSimpleRelationInsert(EState *estate, TupleTableSlot *slot) if (resultRelInfo->ri_PartitionCheck) ExecPartitionCheck(resultRelInfo, slot, estate, true); - /* Store the slot into tuple that we can inspect. */ - tuple = ExecHeapifySlot(slot); - - /* OK, store the tuple and create index entries for it */ - simple_heap_insert(rel, tuple); - - if (resultRelInfo->ri_NumIndices > 0) - recheckIndexes = ExecInsertIndexTuples(slot, &(tuple->t_self), - estate, false, NULL, - NIL); + table_insert(resultRelInfo->ri_RelationDesc, slot, + GetCurrentCommandId(true), 0, NULL, + ExecInsertIndexTuples, estate, NIL, &recheckIndexes); /* AFTER ROW INSERT Triggers */ - ExecARInsertTriggers(estate, resultRelInfo, tuple, + ExecARInsertTriggers(estate, resultRelInfo, slot, recheckIndexes, NULL); /* @@ -404,7 +398,7 @@ ExecSimpleRelationUpdate(EState *estate, EPQState *epqstate, TupleTableSlot *searchslot, TupleTableSlot *slot) { bool skip_tuple = false; - HeapTuple tuple; + TableTuple tuple; ResultRelInfo *resultRelInfo = estate->es_result_relation_info; Relation rel = resultRelInfo->ri_RelationDesc; ItemPointer tid = &(searchslot->tts_tid); @@ -429,6 +423,9 @@ ExecSimpleRelationUpdate(EState *estate, EPQState *epqstate, if (!skip_tuple) { List *recheckIndexes = NIL; + HeapUpdateFailureData hufd; + LockTupleMode lockmode; + InsertIndexTuples IndexFunc = ExecInsertIndexTuples; /* Check the constraints of the tuple */ if (rel->rd_att->constr) @@ -436,17 +433,10 @@ ExecSimpleRelationUpdate(EState *estate, EPQState *epqstate, if (resultRelInfo->ri_PartitionCheck) ExecPartitionCheck(resultRelInfo, slot, estate, true); - /* Store the slot into tuple that we can write. */ - tuple = ExecHeapifySlot(slot); + table_update(rel, tid, slot, estate, GetCurrentCommandId(true), InvalidSnapshot, + true, &hufd, &lockmode, IndexFunc, &recheckIndexes); - /* OK, update the tuple and index entries for it */ - simple_heap_update(rel, tid, tuple); - - if (resultRelInfo->ri_NumIndices > 0 && - !HeapTupleIsHeapOnly(tuple)) - recheckIndexes = ExecInsertIndexTuples(slot, tid, - estate, false, NULL, - NIL); + tuple = ExecHeapifySlot(slot); /* AFTER ROW UPDATE Triggers */ ExecARUpdateTriggers(estate, resultRelInfo, diff --git a/src/backend/executor/nodeLockRows.c b/src/backend/executor/nodeLockRows.c index 30de8a95ab..5c75e46547 100644 --- a/src/backend/executor/nodeLockRows.c +++ b/src/backend/executor/nodeLockRows.c @@ -22,6 +22,7 @@ #include "postgres.h" #include "access/htup_details.h" +#include "access/tableam.h" #include "access/xact.h" #include "executor/executor.h" #include "executor/nodeLockRows.h" @@ -74,18 +75,20 @@ lnext: { ExecAuxRowMark *aerm = (ExecAuxRowMark *) lfirst(lc); ExecRowMark *erm = aerm->rowmark; - HeapTuple *testTuple; + TableTuple *testTuple; Datum datum; bool isNull; - HeapTupleData tuple; + TableTuple tuple; Buffer buffer; HeapUpdateFailureData hufd; LockTupleMode lockmode; HTSU_Result test; - HeapTuple copyTuple; + TableTuple copyTuple; + ItemPointerData tid; + tuple_data t_data; /* clear any leftover test tuple for this rel */ - testTuple = &(node->lr_curtuples[erm->rti - 1]); + testTuple = (TableTuple) (&(node->lr_curtuples[erm->rti - 1])); if (*testTuple != NULL) heap_freetuple(*testTuple); *testTuple = NULL; @@ -159,7 +162,7 @@ lnext: } /* okay, try to lock the tuple */ - tuple.t_self = *((ItemPointer) DatumGetPointer(datum)); + tid = *((ItemPointer) DatumGetPointer(datum)); switch (erm->markType) { case ROW_MARK_EXCLUSIVE: @@ -180,11 +183,13 @@ lnext: break; } - test = heap_lock_tuple(erm->relation, &tuple, - estate->es_output_cid, - lockmode, erm->waitPolicy, true, - &buffer, &hufd); - ReleaseBuffer(buffer); + test = table_lock_tuple(erm->relation, &tid, &tuple, + estate->es_output_cid, + lockmode, erm->waitPolicy, true, + &buffer, &hufd); + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); + switch (test) { case HeapTupleWouldBlock: @@ -223,7 +228,8 @@ lnext: (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE), errmsg("tuple to be locked was already moved to another partition due to concurrent update"))); - if (ItemPointerEquals(&hufd.ctid, &tuple.t_self)) + t_data = erm->relation->rd_tableamroutine->get_tuple_data(tuple, TID); + if (ItemPointerEquals(&hufd.ctid, &(t_data.tid))) { /* Tuple was deleted, so don't return it */ goto lnext; @@ -243,7 +249,8 @@ lnext: goto lnext; } /* remember the actually locked tuple's TID */ - tuple.t_self = copyTuple->t_self; + t_data = erm->relation->rd_tableamroutine->get_tuple_data(copyTuple, TID); + tid = t_data.tid; /* Save locked tuple for EvalPlanQual testing below */ *testTuple = copyTuple; @@ -264,7 +271,7 @@ lnext: } /* Remember locked tuple's TID for EPQ testing and WHERE CURRENT OF */ - erm->curCtid = tuple.t_self; + erm->curCtid = tid; } /* @@ -286,7 +293,7 @@ lnext: { ExecAuxRowMark *aerm = (ExecAuxRowMark *) lfirst(lc); ExecRowMark *erm = aerm->rowmark; - HeapTupleData tuple; + TableTuple tuple; Buffer buffer; /* skip non-active child tables, but clear their test tuples */ @@ -314,14 +321,12 @@ lnext: Assert(ItemPointerIsValid(&(erm->curCtid))); /* okay, fetch the tuple */ - tuple.t_self = erm->curCtid; - if (!heap_fetch(erm->relation, SnapshotAny, &tuple, &buffer, - false, NULL)) + if (!table_fetch(erm->relation, &erm->curCtid, SnapshotAny, &tuple, &buffer, + false, NULL)) elog(ERROR, "failed to fetch tuple for EvalPlanQual recheck"); /* successful, copy and store tuple */ - EvalPlanQualSetTuple(&node->lr_epqstate, erm->rti, - heap_copytuple(&tuple)); + EvalPlanQualSetTuple(&node->lr_epqstate, erm->rti, tuple); ReleaseBuffer(buffer); } @@ -401,8 +406,8 @@ ExecInitLockRows(LockRows *node, EState *estate, int eflags) * Create workspace in which we can remember per-RTE locked tuples */ lrstate->lr_ntables = list_length(estate->es_range_table); - lrstate->lr_curtuples = (HeapTuple *) - palloc0(lrstate->lr_ntables * sizeof(HeapTuple)); + lrstate->lr_curtuples = (TableTuple *) + palloc0(lrstate->lr_ntables * sizeof(TableTuple)); /* * Locate the ExecRowMark(s) that this node is responsible for, and diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c index 4300ac44bd..99347845da 100644 --- a/src/backend/executor/nodeModifyTable.c +++ b/src/backend/executor/nodeModifyTable.c @@ -38,7 +38,9 @@ #include "postgres.h" #include "access/htup_details.h" +#include "access/tableam.h" #include "access/xact.h" +#include "catalog/pg_am.h" #include "commands/trigger.h" #include "executor/execPartition.h" #include "executor/executor.h" @@ -174,15 +176,13 @@ ExecProcessReturning(ResultRelInfo *resultRelInfo, econtext->ecxt_scantuple = tupleSlot; else { - HeapTuple tuple; - /* * RETURNING expressions might reference the tableoid column, so * initialize t_tableOid before evaluating them. */ Assert(!TupIsNull(econtext->ecxt_scantuple)); - tuple = ExecHeapifySlot(econtext->ecxt_scantuple); - tuple->t_tableOid = RelationGetRelid(resultRelInfo->ri_RelationDesc); + ExecSlotUpdateTupleTableoid(econtext->ecxt_scantuple, + RelationGetRelid(resultRelInfo->ri_RelationDesc)); } econtext->ecxt_outertuple = planSlot; @@ -201,7 +201,7 @@ ExecProcessReturning(ResultRelInfo *resultRelInfo, static void ExecCheckHeapTupleVisible(EState *estate, Relation rel, - HeapTuple tuple, + TableTuple tuple, Buffer buffer) { if (!IsolationUsesXactSnapshot()) @@ -214,13 +214,15 @@ ExecCheckHeapTupleVisible(EState *estate, LockBuffer(buffer, BUFFER_LOCK_SHARE); if (!HeapTupleSatisfiesVisibility(rel->rd_tableamroutine, tuple, estate->es_snapshot, buffer)) { + tuple_data t_data = table_tuple_get_data(rel, tuple, XMIN); + /* * We should not raise a serialization failure if the conflict is * against a tuple inserted by our own transaction, even if it's not * visible to our snapshot. (This would happen, for example, if * conflicting keys are proposed for insertion in a single command.) */ - if (!TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetXmin(tuple->t_data))) + if (!TransactionIdIsCurrentTransactionId(t_data.xid)) ereport(ERROR, (errcode(ERRCODE_T_R_SERIALIZATION_FAILURE), errmsg("could not serialize access due to concurrent update"))); @@ -236,19 +238,20 @@ ExecCheckTIDVisible(EState *estate, ResultRelInfo *relinfo, ItemPointer tid) { - Relation rel = relinfo->ri_RelationDesc; Buffer buffer; - HeapTupleData tuple; + Relation rel = relinfo->ri_RelationDesc; + TableTuple tuple; /* Redundantly check isolation level */ if (!IsolationUsesXactSnapshot()) return; - tuple.t_self = *tid; - if (!heap_fetch(rel, SnapshotAny, &tuple, &buffer, false, NULL)) + if (!table_fetch(rel, tid, SnapshotAny, &tuple, &buffer, false, NULL)) elog(ERROR, "failed to fetch conflicting tuple for ON CONFLICT"); - ExecCheckHeapTupleVisible(estate, rel, &tuple, buffer); - ReleaseBuffer(buffer); + ExecCheckHeapTupleVisible(estate, rel, tuple, buffer); + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); + pfree(tuple); } /* ---------------------------------------------------------------- @@ -267,7 +270,7 @@ ExecInsert(ModifyTableState *mtstate, EState *estate, bool canSetTag) { - HeapTuple tuple; + TableTuple tuple; ResultRelInfo *resultRelInfo; Relation resultRelationDesc; Oid newId; @@ -277,32 +280,32 @@ ExecInsert(ModifyTableState *mtstate, ModifyTable *node = (ModifyTable *) mtstate->ps.plan; OnConflictAction onconflict = node->onConflictAction; - /* - * get the heap tuple out of the tuple table slot, making sure we have a - * writable copy - */ - tuple = ExecHeapifySlot(slot); - /* * get information on the (current) result relation */ resultRelInfo = estate->es_result_relation_info; resultRelationDesc = resultRelInfo->ri_RelationDesc; + + ExecMaterializeSlot(slot); + /* - * If the result relation has OIDs, force the tuple's OID to zero so that - * heap_insert will assign a fresh OID. Usually the OID already will be - * zero at this point, but there are corner cases where the plan tree can - * return a tuple extracted literally from some table with the same - * rowtype. + * If the result relation uses heapam and has OIDs, force the tuple's OID + * to zero so that heap_insert will assign a fresh OID. Usually the OID + * already will be zero at this point, but there are corner cases where + * the plan tree can return a tuple extracted literally from some table + * with the same rowtype. * * XXX if we ever wanted to allow users to assign their own OIDs to new * rows, this'd be the place to do it. For the moment, we make a point of * doing this before calling triggers, so that a user-supplied trigger * could hack the OID if desired. */ - if (resultRelationDesc->rd_rel->relhasoids) - HeapTupleSetOid(tuple, InvalidOid); + if (resultRelationDesc->rd_rel->relam == HEAP_TABLE_AM_OID && + resultRelationDesc->rd_rel->relhasoids) + { + slot->tts_tupleOid = InvalidOid; + } /* * BEFORE ROW INSERT Triggers. @@ -320,9 +323,6 @@ ExecInsert(ModifyTableState *mtstate, if (slot == NULL) /* "do nothing" */ return NULL; - - /* trigger might have changed tuple */ - tuple = ExecHeapifySlot(slot); } /* INSTEAD OF ROW INSERT Triggers */ @@ -334,9 +334,6 @@ ExecInsert(ModifyTableState *mtstate, if (slot == NULL) /* "do nothing" */ return NULL; - /* trigger might have changed tuple */ - tuple = ExecHeapifySlot(slot); - newId = InvalidOid; } else if (resultRelInfo->ri_FdwRoutine) @@ -352,14 +349,12 @@ ExecInsert(ModifyTableState *mtstate, if (slot == NULL) /* "do nothing" */ return NULL; - /* FDW might have changed tuple */ - tuple = ExecHeapifySlot(slot); - /* * AFTER ROW Triggers or RETURNING expressions might reference the * tableoid column, so initialize t_tableOid before evaluating them. */ - tuple->t_tableOid = RelationGetRelid(resultRelationDesc); + slot->tts_tableOid = RelationGetRelid(resultRelationDesc); + ExecSlotUpdateTupleTableoid(slot, slot->tts_tableOid); newId = InvalidOid; } @@ -371,7 +366,8 @@ ExecInsert(ModifyTableState *mtstate, * Constraints might reference the tableoid column, so initialize * t_tableOid before evaluating them. */ - tuple->t_tableOid = RelationGetRelid(resultRelationDesc); + slot->tts_tableOid = RelationGetRelid(resultRelationDesc); + ExecSlotUpdateTupleTableoid(slot, slot->tts_tableOid); /* * Check any RLS WITH CHECK policies. @@ -414,7 +410,6 @@ ExecInsert(ModifyTableState *mtstate, /* Perform a speculative insertion. */ uint32 specToken; ItemPointerData conflictTid; - bool specConflict; List *arbiterIndexes; arbiterIndexes = resultRelInfo->ri_onConflictArbiterIndexes; @@ -432,7 +427,7 @@ ExecInsert(ModifyTableState *mtstate, * speculatively. */ vlock: - specConflict = false; + slot->tts_specConflict = false; if (!ExecCheckIndexConstraints(slot, estate, &conflictTid, arbiterIndexes)) { @@ -478,24 +473,17 @@ ExecInsert(ModifyTableState *mtstate, * waiting for the whole transaction to complete. */ specToken = SpeculativeInsertionLockAcquire(GetCurrentTransactionId()); - HeapTupleHeaderSetSpeculativeToken(tuple->t_data, specToken); + slot->tts_speculativeToken = specToken; /* insert the tuple, with the speculative token */ - newId = heap_insert(resultRelationDesc, tuple, - estate->es_output_cid, - HEAP_INSERT_SPECULATIVE, - NULL); - - /* insert index entries for tuple */ - recheckIndexes = ExecInsertIndexTuples(slot, &(tuple->t_self), - estate, true, &specConflict, - arbiterIndexes); - - /* adjust the tuple's state accordingly */ - if (!specConflict) - heap_finish_speculative(resultRelationDesc, tuple); - else - heap_abort_speculative(resultRelationDesc, tuple); + newId = table_insert(resultRelationDesc, slot, + estate->es_output_cid, + HEAP_INSERT_SPECULATIVE, + NULL, + ExecInsertIndexTuples, + estate, + arbiterIndexes, + &recheckIndexes); /* * Wake up anyone waiting for our decision. They will re-check @@ -511,7 +499,7 @@ ExecInsert(ModifyTableState *mtstate, * the pre-check again, which will now find the conflicting tuple * (unless it aborts before we get there). */ - if (specConflict) + if (slot->tts_specConflict) { list_free(recheckIndexes); goto vlock; @@ -523,19 +511,14 @@ ExecInsert(ModifyTableState *mtstate, { /* * insert the tuple normally. - * - * Note: heap_insert returns the tid (location) of the new tuple - * in the t_self field. */ - newId = heap_insert(resultRelationDesc, tuple, - estate->es_output_cid, - 0, NULL); - - /* insert index entries for tuple */ - if (resultRelInfo->ri_NumIndices > 0) - recheckIndexes = ExecInsertIndexTuples(slot, &(tuple->t_self), - estate, false, NULL, - NIL); + newId = table_insert(resultRelationDesc, slot, + estate->es_output_cid, + 0, NULL, + ExecInsertIndexTuples, + estate, + NIL, + &recheckIndexes); } } @@ -543,7 +526,7 @@ ExecInsert(ModifyTableState *mtstate, { (estate->es_processed)++; estate->es_lastoid = newId; - setLastTid(&(tuple->t_self)); + setLastTid(&(slot->tts_tid)); } /* @@ -556,6 +539,7 @@ ExecInsert(ModifyTableState *mtstate, if (mtstate->operation == CMD_UPDATE && mtstate->mt_transition_capture && mtstate->mt_transition_capture->tcs_update_new_table) { + tuple = ExecHeapifySlot(slot); ExecARUpdateTriggers(estate, resultRelInfo, NULL, NULL, tuple, @@ -570,7 +554,7 @@ ExecInsert(ModifyTableState *mtstate, } /* AFTER ROW INSERT Triggers */ - ExecARInsertTriggers(estate, resultRelInfo, tuple, recheckIndexes, + ExecARInsertTriggers(estate, resultRelInfo, slot, recheckIndexes, ar_insert_trig_tcs); list_free(recheckIndexes); @@ -618,7 +602,7 @@ ExecInsert(ModifyTableState *mtstate, static TupleTableSlot * ExecDelete(ModifyTableState *mtstate, ItemPointer tupleid, - HeapTuple oldtuple, + TableTuple oldtuple, TupleTableSlot *planSlot, EPQState *epqstate, EState *estate, @@ -670,8 +654,6 @@ ExecDelete(ModifyTableState *mtstate, } else if (resultRelInfo->ri_FdwRoutine) { - HeapTuple tuple; - /* * delete from foreign table: let the FDW do it * @@ -697,8 +679,10 @@ ExecDelete(ModifyTableState *mtstate, */ if (slot->tts_isempty) ExecStoreAllNullTuple(slot); - tuple = ExecHeapifySlot(slot); - tuple->t_tableOid = RelationGetRelid(resultRelationDesc); + + ExecMaterializeSlot(slot); + + slot->tts_tableOid = RelationGetRelid(resultRelationDesc); } else { @@ -712,10 +696,11 @@ ExecDelete(ModifyTableState *mtstate, * mode transactions. */ ldelete:; - result = heap_delete(resultRelationDesc, tupleid, + result = table_delete(resultRelationDesc, tupleid, estate->es_output_cid, estate->es_crosscheck_snapshot, true /* wait for commit */ , + NULL, &hufd, changingPart); switch (result) @@ -846,7 +831,7 @@ ldelete:; * gotta fetch it. We can use the trigger tuple slot. */ TupleTableSlot *rslot; - HeapTupleData deltuple; + TableTuple deltuple = NULL; Buffer delbuffer; if (resultRelInfo->ri_FdwRoutine) @@ -860,20 +845,19 @@ ldelete:; slot = estate->es_trig_tuple_slot; if (oldtuple != NULL) { - deltuple = *oldtuple; + deltuple = heap_copytuple(oldtuple); delbuffer = InvalidBuffer; } else { - deltuple.t_self = *tupleid; - if (!heap_fetch(resultRelationDesc, SnapshotAny, - &deltuple, &delbuffer, false, NULL)) + if (!table_fetch(resultRelationDesc, tupleid, SnapshotAny, + &deltuple, &delbuffer, false, NULL)) elog(ERROR, "failed to fetch deleted tuple for DELETE RETURNING"); } if (slot->tts_tupleDescriptor != RelationGetDescr(resultRelationDesc)) ExecSetSlotDescriptor(slot, RelationGetDescr(resultRelationDesc)); - ExecStoreTuple(&deltuple, slot, InvalidBuffer, false); + ExecStoreTuple(deltuple, slot, InvalidBuffer, false); } rslot = ExecProcessReturning(resultRelInfo, slot, planSlot); @@ -882,7 +866,7 @@ ldelete:; * Before releasing the target tuple again, make sure rslot has a * local copy of any pass-by-reference values. */ - ExecHeapifySlot(rslot); + ExecMaterializeSlot(rslot); ExecClearTuple(slot); if (BufferIsValid(delbuffer)) @@ -919,14 +903,14 @@ ldelete:; static TupleTableSlot * ExecUpdate(ModifyTableState *mtstate, ItemPointer tupleid, - HeapTuple oldtuple, + TableTuple oldtuple, TupleTableSlot *slot, TupleTableSlot *planSlot, EPQState *epqstate, EState *estate, bool canSetTag) { - HeapTuple tuple; + TableTuple tuple; ResultRelInfo *resultRelInfo; Relation resultRelationDesc; HTSU_Result result; @@ -992,14 +976,14 @@ ExecUpdate(ModifyTableState *mtstate, if (slot == NULL) /* "do nothing" */ return NULL; - /* FDW might have changed tuple */ - tuple = ExecHeapifySlot(slot); - /* * AFTER ROW Triggers or RETURNING expressions might reference the * tableoid column, so initialize t_tableOid before evaluating them. */ - tuple->t_tableOid = RelationGetRelid(resultRelationDesc); + ExecSlotUpdateTupleTableoid(slot, RelationGetRelid(resultRelationDesc)); + + /* FDW might have changed tuple */ + tuple = ExecHeapifySlot(slot); } else { @@ -1010,7 +994,7 @@ ExecUpdate(ModifyTableState *mtstate, * Constraints might reference the tableoid column, so initialize * t_tableOid before evaluating them. */ - tuple->t_tableOid = RelationGetRelid(resultRelationDesc); + slot->tts_tableOid = RelationGetRelid(resultRelationDesc); /* * Check any RLS UPDATE WITH CHECK policies @@ -1174,11 +1158,14 @@ lreplace:; * needed for referential integrity updates in transaction-snapshot * mode transactions. */ - result = heap_update(resultRelationDesc, tupleid, tuple, - estate->es_output_cid, - estate->es_crosscheck_snapshot, - true /* wait for commit */ , - &hufd, &lockmode); + result = table_update(resultRelationDesc, tupleid, slot, + estate, + estate->es_output_cid, + estate->es_crosscheck_snapshot, + true /* wait for commit */ , + &hufd, &lockmode, + ExecInsertIndexTuples, + &recheckIndexes); switch (result) { case HeapTupleSelfUpdated: @@ -1254,26 +1241,6 @@ lreplace:; elog(ERROR, "unrecognized heap_update status: %u", result); return NULL; } - - /* - * Note: instead of having to update the old index tuples associated - * with the heap tuple, all we do is form and insert new index tuples. - * This is because UPDATEs are actually DELETEs and INSERTs, and index - * tuple deletion is done later by VACUUM (see notes in ExecDelete). - * All we do here is insert new index tuples. -cim 9/27/89 - */ - - /* - * insert index entries for tuple - * - * Note: heap_update returns the tid (location) of the new tuple in - * the t_self field. - * - * If it's a HOT update, we mustn't insert new index entries. - */ - if (resultRelInfo->ri_NumIndices > 0 && !HeapTupleIsHeapOnly(tuple)) - recheckIndexes = ExecInsertIndexTuples(slot, &(tuple->t_self), - estate, false, NULL, NIL); } if (canSetTag) @@ -1331,11 +1298,12 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, ExprContext *econtext = mtstate->ps.ps_ExprContext; Relation relation = resultRelInfo->ri_RelationDesc; ExprState *onConflictSetWhere = resultRelInfo->ri_onConflict->oc_WhereClause; - HeapTupleData tuple; + TableTuple tuple = NULL; HeapUpdateFailureData hufd; LockTupleMode lockmode; HTSU_Result test; Buffer buffer; + tuple_data t_data; /* Determine lock mode to use */ lockmode = ExecUpdateLockMode(estate, resultRelInfo); @@ -1346,10 +1314,8 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, * previous conclusion that the tuple is conclusively committed is not * true anymore. */ - tuple.t_self = *conflictTid; - test = heap_lock_tuple(relation, &tuple, estate->es_output_cid, - lockmode, LockWaitBlock, false, &buffer, - &hufd); + test = table_lock_tuple(relation, conflictTid, &tuple, estate->es_output_cid, + lockmode, LockWaitBlock, false, &buffer, &hufd); switch (test) { case HeapTupleMayBeUpdated: @@ -1374,7 +1340,8 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, * that for SQL MERGE, an exception must be raised in the event of * an attempt to update the same row twice. */ - if (TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetXmin(tuple.t_data))) + t_data = table_tuple_get_data(relation, tuple, XMIN); + if (TransactionIdIsCurrentTransactionId(t_data.xid)) ereport(ERROR, (errcode(ERRCODE_CARDINALITY_VIOLATION), errmsg("ON CONFLICT DO UPDATE command cannot affect row a second time"), @@ -1415,7 +1382,9 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, * loop here, as the new version of the row might not conflict * anymore, or the conflicting tuple has actually been deleted. */ - ReleaseBuffer(buffer); + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); + pfree(tuple); return false; default: @@ -1443,10 +1412,10 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, * snapshot. This is in line with the way UPDATE deals with newer tuple * versions. */ - ExecCheckHeapTupleVisible(estate, relation, &tuple, buffer); + ExecCheckHeapTupleVisible(estate, relation, tuple, buffer); /* Store target's existing tuple in the state's dedicated slot */ - ExecStoreTuple(&tuple, mtstate->mt_existing, buffer, false); + ExecStoreTuple(tuple, mtstate->mt_existing, buffer, false); /* * Make tuple and any needed join variables available to ExecQual and @@ -1461,7 +1430,9 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, if (!ExecQual(onConflictSetWhere, econtext)) { - ReleaseBuffer(buffer); + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); + pfree(tuple); InstrCountFiltered1(&mtstate->ps, 1); return true; /* done with the tuple */ } @@ -1501,12 +1472,14 @@ ExecOnConflictUpdate(ModifyTableState *mtstate, */ /* Execute UPDATE with projection */ - *returning = ExecUpdate(mtstate, &tuple.t_self, NULL, + *returning = ExecUpdate(mtstate, conflictTid, NULL, mtstate->mt_conflproj, planSlot, &mtstate->mt_epqstate, mtstate->ps.state, canSetTag); - ReleaseBuffer(buffer); + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); + pfree(tuple); return true; } @@ -1926,7 +1899,7 @@ ExecModifyTable(PlanState *pstate) ItemPointer tupleid; ItemPointerData tuple_ctid; HeapTupleData oldtupdata; - HeapTuple oldtuple; + TableTuple oldtuple; CHECK_FOR_INTERRUPTS(); diff --git a/src/backend/executor/nodeTidscan.c b/src/backend/executor/nodeTidscan.c index e207b1ffb5..3d4e8d0093 100644 --- a/src/backend/executor/nodeTidscan.c +++ b/src/backend/executor/nodeTidscan.c @@ -22,6 +22,7 @@ */ #include "postgres.h" +#include "access/tableam.h" #include "access/sysattr.h" #include "catalog/pg_type.h" #include "executor/execdebug.h" @@ -306,7 +307,7 @@ TidNext(TidScanState *node) ScanDirection direction; Snapshot snapshot; Relation heapRelation; - HeapTuple tuple; + TableTuple tuple; TupleTableSlot *slot; Buffer buffer = InvalidBuffer; ItemPointerData *tidList; @@ -331,12 +332,6 @@ TidNext(TidScanState *node) tidList = node->tss_TidList; numTids = node->tss_NumTids; - /* - * We use node->tss_htup as the tuple pointer; note this can't just be a - * local variable here, as the scan tuple slot will keep a pointer to it. - */ - tuple = &(node->tss_htup); - /* * Initialize or advance scan position, depending on direction. */ @@ -364,7 +359,7 @@ TidNext(TidScanState *node) while (node->tss_TidPtr >= 0 && node->tss_TidPtr < numTids) { - tuple->t_self = tidList[node->tss_TidPtr]; + ItemPointerData tid = tidList[node->tss_TidPtr]; /* * For WHERE CURRENT OF, the tuple retrieved from the cursor might @@ -372,9 +367,9 @@ TidNext(TidScanState *node) * current according to our snapshot. */ if (node->tss_isCurrentOf) - heap_get_latest_tid(heapRelation, snapshot, &tuple->t_self); + table_get_latest_tid(heapRelation, snapshot, &tid); - if (heap_fetch(heapRelation, snapshot, tuple, &buffer, false, NULL)) + if (table_fetch(heapRelation, &tid, snapshot, &tuple, &buffer, false, NULL)) { /* * store the scanned tuple in the scan tuple slot of the scan @@ -385,14 +380,16 @@ TidNext(TidScanState *node) */ ExecStoreTuple(tuple, /* tuple to store */ slot, /* slot to store in */ - buffer, /* buffer associated with tuple */ - false); /* don't pfree */ + InvalidBuffer, /* buffer associated with tuple */ + true); /* don't pfree */ /* * At this point we have an extra pin on the buffer, because * ExecStoreTuple incremented the pin count. Drop our local pin. */ - ReleaseBuffer(buffer); + /* hari */ + if (BufferIsValid(buffer)) + ReleaseBuffer(buffer); return slot; } diff --git a/src/backend/utils/adt/tid.c b/src/backend/utils/adt/tid.c index 41d540b46e..bb8a683b44 100644 --- a/src/backend/utils/adt/tid.c +++ b/src/backend/utils/adt/tid.c @@ -22,6 +22,7 @@ #include "access/heapam.h" #include "access/sysattr.h" +#include "access/tableam.h" #include "catalog/namespace.h" #include "catalog/pg_type.h" #include "libpq/pqformat.h" @@ -352,7 +353,7 @@ currtid_byreloid(PG_FUNCTION_ARGS) ItemPointerCopy(tid, result); snapshot = RegisterSnapshot(GetLatestSnapshot()); - heap_get_latest_tid(rel, snapshot, result); + table_get_latest_tid(rel, snapshot, result); UnregisterSnapshot(snapshot); heap_close(rel, AccessShareLock); @@ -387,7 +388,7 @@ currtid_byrelname(PG_FUNCTION_ARGS) ItemPointerCopy(tid, result); snapshot = RegisterSnapshot(GetLatestSnapshot()); - heap_get_latest_tid(rel, snapshot, result); + table_get_latest_tid(rel, snapshot, result); UnregisterSnapshot(snapshot); heap_close(rel, AccessShareLock); diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h index 23f97df249..f660807147 100644 --- a/src/include/access/heapam.h +++ b/src/include/access/heapam.h @@ -134,7 +134,7 @@ extern void heap_parallelscan_initialize(ParallelHeapScanDesc target, extern void heap_parallelscan_reinitialize(ParallelHeapScanDesc parallel_scan); extern HeapScanDesc heap_beginscan_parallel(Relation, ParallelHeapScanDesc); -extern bool heap_fetch(Relation relation, Snapshot snapshot, +extern bool heap_fetch(Relation relation, ItemPointer tid, Snapshot snapshot, HeapTuple tuple, Buffer *userbuf, bool keep_buf, Relation stats_relation); extern bool heap_hot_search_buffer(ItemPointer tid, Relation relation, @@ -142,7 +142,6 @@ extern bool heap_hot_search_buffer(ItemPointer tid, Relation relation, bool *all_dead, bool first_call); extern bool heap_hot_search(ItemPointer tid, Relation relation, Snapshot snapshot, bool *all_dead); - extern void heap_get_latest_tid(Relation relation, Snapshot snapshot, ItemPointer tid); extern void setLastTid(const ItemPointer tid); @@ -158,8 +157,8 @@ extern void heap_multi_insert(Relation relation, HeapTuple *tuples, int ntuples, extern HTSU_Result heap_delete(Relation relation, ItemPointer tid, CommandId cid, Snapshot crosscheck, bool wait, HeapUpdateFailureData *hufd, bool changingPart); -extern void heap_finish_speculative(Relation relation, HeapTuple tuple); -extern void heap_abort_speculative(Relation relation, HeapTuple tuple); +extern void heap_finish_speculative(Relation relation, TupleTableSlot *slot); +extern void heap_abort_speculative(Relation relation, TupleTableSlot *slot); extern HTSU_Result heap_update(Relation relation, ItemPointer otid, HeapTuple newtup, CommandId cid, Snapshot crosscheck, bool wait, @@ -168,6 +167,7 @@ extern HTSU_Result heap_lock_tuple(Relation relation, HeapTuple tuple, CommandId cid, LockTupleMode mode, LockWaitPolicy wait_policy, bool follow_update, Buffer *buffer, HeapUpdateFailureData *hufd); + extern void heap_inplace_update(Relation relation, HeapTuple tuple); extern bool heap_freeze_tuple(HeapTupleHeader tuple, TransactionId relfrozenxid, TransactionId relminmxid, diff --git a/src/include/access/htup_details.h b/src/include/access/htup_details.h index 4db9303abb..2845d70cc2 100644 --- a/src/include/access/htup_details.h +++ b/src/include/access/htup_details.h @@ -825,6 +825,7 @@ extern Datum heap_getsysattr(HeapTuple tup, int attnum, TupleDesc tupleDesc, extern HeapTuple heap_copytuple(HeapTuple tuple); extern void heap_copytuple_with_tuple(HeapTuple src, HeapTuple dest); extern Datum heap_copy_tuple_as_datum(HeapTuple tuple, TupleDesc tupleDesc); +extern HeapTuple heap_form_tuple_by_datum(Datum data, Oid relid); extern HeapTuple heap_form_tuple(TupleDesc tupleDescriptor, Datum *values, bool *isnull); extern HeapTuple heap_modify_tuple(HeapTuple tuple, diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h new file mode 100644 index 0000000000..1df7adf209 --- /dev/null +++ b/src/include/access/tableam.h @@ -0,0 +1,84 @@ +/*------------------------------------------------------------------------- + * + * tableam.h + * POSTGRES table access method definitions. + * + * + * Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group + * Portions Copyright (c) 1994, Regents of the University of California + * + * src/include/access/tableam.h + * + *------------------------------------------------------------------------- + */ +#ifndef TABLEAM_H +#define TABLEAM_H + +#include "access/heapam.h" +#include "access/tableam_common.h" +#include "executor/tuptable.h" +#include "nodes/execnodes.h" + +typedef union tuple_data +{ + TransactionId xid; + CommandId cid; + ItemPointerData tid; +} tuple_data; + +typedef enum tuple_data_flags +{ + XMIN = 0, + UPDATED_XID, + CMIN, + TID, + CTID +} tuple_data_flags; + +/* Function pointer to let the index tuple insert from storage am */ +typedef List *(*InsertIndexTuples) (TupleTableSlot *slot, EState *estate, bool noDupErr, + bool *specConflict, List *arbiterIndexes); + +/* Function pointer to let the index tuple delete from storage am */ +typedef void (*DeleteIndexTuples) (Relation rel, ItemPointer tid, TransactionId old_xmin); + +extern bool table_fetch(Relation relation, + ItemPointer tid, + Snapshot snapshot, + TableTuple * stuple, + Buffer *userbuf, + bool keep_buf, + Relation stats_relation); + +extern HTSU_Result table_lock_tuple(Relation relation, ItemPointer tid, TableTuple * stuple, + CommandId cid, LockTupleMode mode, LockWaitPolicy wait_policy, + bool follow_updates, + Buffer *buffer, HeapUpdateFailureData *hufd); + +extern Oid table_insert(Relation relation, TupleTableSlot *slot, CommandId cid, + int options, BulkInsertState bistate, InsertIndexTuples IndexFunc, + EState *estate, List *arbiterIndexes, List **recheckIndexes); + +extern HTSU_Result table_delete(Relation relation, ItemPointer tid, CommandId cid, + Snapshot crosscheck, bool wait, DeleteIndexTuples IndexFunc, + HeapUpdateFailureData *hufd, bool changingPart); + +extern HTSU_Result table_update(Relation relation, ItemPointer otid, TupleTableSlot *slot, + EState *estate, CommandId cid, Snapshot crosscheck, bool wait, + HeapUpdateFailureData *hufd, LockTupleMode *lockmode, + InsertIndexTuples IndexFunc, List **recheckIndexes); + +extern void table_multi_insert(Relation relation, HeapTuple *tuples, int ntuples, + CommandId cid, int options, BulkInsertState bistate); + +extern tuple_data table_tuple_get_data(Relation relation, TableTuple tuple, tuple_data_flags flags); + +extern TableTuple table_tuple_by_datum(Relation relation, Datum data, Oid tableoid); + +extern void table_get_latest_tid(Relation relation, + Snapshot snapshot, + ItemPointer tid); + +extern void table_sync(Relation rel); + +#endif /* TABLEAM_H */ diff --git a/src/include/access/tableam_common.h b/src/include/access/tableam_common.h index fd44cd0b94..e5cc461bd8 100644 --- a/src/include/access/tableam_common.h +++ b/src/include/access/tableam_common.h @@ -56,9 +56,6 @@ typedef MinimalTuple (*SlotGetMinTuple_function) (TupleTableSlot *slot, bool pal typedef void (*SlotUpdateTableoid_function) (TupleTableSlot *slot, Oid tableoid); -typedef void (*SpeculativeAbort_function) (Relation rel, - TupleTableSlot *slot); - typedef struct SlotTableAmRoutine { /* Operations on TupleTableSlot */ diff --git a/src/include/access/tableamapi.h b/src/include/access/tableamapi.h index 03d6cd42f3..8b9812068a 100644 --- a/src/include/access/tableamapi.h +++ b/src/include/access/tableamapi.h @@ -11,7 +11,9 @@ #ifndef TABLEEAMAPI_H #define TABLEEAMAPI_H -#include "access/tableam_common.h" +#include "access/heapam.h" +#include "access/tableam.h" +#include "nodes/execnodes.h" #include "nodes/nodes.h" #include "fmgr.h" #include "utils/snapshot.h" @@ -24,6 +26,62 @@ typedef bool (*SnapshotSatisfies_function) (TableTuple htup, Snapshot snapshot, typedef HTSU_Result (*SnapshotSatisfiesUpdate_function) (TableTuple htup, CommandId curcid, Buffer buffer); typedef HTSV_Result (*SnapshotSatisfiesVacuum_function) (TableTuple htup, TransactionId OldestXmin, Buffer buffer); +typedef Oid (*TupleInsert_function) (Relation rel, TupleTableSlot *slot, CommandId cid, + int options, BulkInsertState bistate, InsertIndexTuples IndexFunc, + EState *estate, List *arbiterIndexes, List **recheckIndexes); + +typedef HTSU_Result (*TupleDelete_function) (Relation relation, + ItemPointer tid, + CommandId cid, + Snapshot crosscheck, + bool wait, + DeleteIndexTuples IndexFunc, + HeapUpdateFailureData *hufd, + bool changingPart); + +typedef HTSU_Result (*TupleUpdate_function) (Relation relation, + ItemPointer otid, + TupleTableSlot *slot, + EState *estate, + CommandId cid, + Snapshot crosscheck, + bool wait, + HeapUpdateFailureData *hufd, + LockTupleMode *lockmode, + InsertIndexTuples IndexFunc, + List **recheckIndexes); + +typedef bool (*TupleFetch_function) (Relation relation, + ItemPointer tid, + Snapshot snapshot, + TableTuple * tuple, + Buffer *userbuf, + bool keep_buf, + Relation stats_relation); + +typedef HTSU_Result (*TupleLock_function) (Relation relation, + ItemPointer tid, + TableTuple * tuple, + CommandId cid, + LockTupleMode mode, + LockWaitPolicy wait_policy, + bool follow_update, + Buffer *buffer, + HeapUpdateFailureData *hufd); + +typedef void (*MultiInsert_function) (Relation relation, HeapTuple *tuples, int ntuples, + CommandId cid, int options, BulkInsertState bistate); + +typedef void (*TupleGetLatestTid_function) (Relation relation, + Snapshot snapshot, + ItemPointer tid); + +typedef tuple_data(*GetTupleData_function) (TableTuple tuple, tuple_data_flags flags); + +typedef TableTuple(*TupleFromDatum_function) (Datum data, Oid tableoid); + +typedef void (*RelationSync_function) (Relation relation); + /* * API struct for a table AM. Note this must be stored in a single palloc'd * chunk of memory. @@ -43,6 +101,20 @@ typedef struct TableAmRoutine slot_tableam_hook slot_storageam; + /* Operations on physical tuples */ + TupleInsert_function tuple_insert; /* heap_insert */ + TupleUpdate_function tuple_update; /* heap_update */ + TupleDelete_function tuple_delete; /* heap_delete */ + TupleFetch_function tuple_fetch; /* heap_fetch */ + TupleLock_function tuple_lock; /* heap_lock_tuple */ + MultiInsert_function multi_insert; /* heap_multi_insert */ + TupleGetLatestTid_function tuple_get_latest_tid; /* heap_get_latest_tid */ + + GetTupleData_function get_tuple_data; + TupleFromDatum_function tuple_from_datum; + + RelationSync_function relation_sync; /* heap_sync */ + } TableAmRoutine; extern TableAmRoutine * GetTableAmRoutine(Oid amhandler); diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h index a5b8610fa2..2fe7ed33a5 100644 --- a/src/include/commands/trigger.h +++ b/src/include/commands/trigger.h @@ -191,7 +191,7 @@ extern TupleTableSlot *ExecBRInsertTriggers(EState *estate, TupleTableSlot *slot); extern void ExecARInsertTriggers(EState *estate, ResultRelInfo *relinfo, - HeapTuple trigtuple, + TupleTableSlot *slot, List *recheckIndexes, TransitionCaptureState *transition_capture); extern TupleTableSlot *ExecIRInsertTriggers(EState *estate, diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index f82b51667f..406572771b 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -193,16 +193,16 @@ extern ExecAuxRowMark *ExecBuildAuxRowMark(ExecRowMark *erm, List *targetlist); extern TupleTableSlot *EvalPlanQual(EState *estate, EPQState *epqstate, Relation relation, Index rti, int lockmode, ItemPointer tid, TransactionId priorXmax); -extern HeapTuple EvalPlanQualFetch(EState *estate, Relation relation, - int lockmode, LockWaitPolicy wait_policy, ItemPointer tid, - TransactionId priorXmax); +extern TableTuple EvalPlanQualFetch(EState *estate, Relation relation, + int lockmode, LockWaitPolicy wait_policy, ItemPointer tid, + TransactionId priorXmax); extern void EvalPlanQualInit(EPQState *epqstate, EState *estate, Plan *subplan, List *auxrowmarks, int epqParam); extern void EvalPlanQualSetPlan(EPQState *epqstate, Plan *subplan, List *auxrowmarks); extern void EvalPlanQualSetTuple(EPQState *epqstate, Index rti, - HeapTuple tuple); -extern HeapTuple EvalPlanQualGetTuple(EPQState *epqstate, Index rti); + TableTuple tuple); +extern TableTuple EvalPlanQualGetTuple(EPQState *epqstate, Index rti); #define EvalPlanQualSetSlot(epqstate, slot) ((epqstate)->origslot = (slot)) extern void EvalPlanQualFetchRowMarks(EPQState *epqstate); @@ -539,9 +539,8 @@ extern int ExecCleanTargetListLength(List *targetlist); */ extern void ExecOpenIndices(ResultRelInfo *resultRelInfo, bool speculative); extern void ExecCloseIndices(ResultRelInfo *resultRelInfo); -extern List *ExecInsertIndexTuples(TupleTableSlot *slot, ItemPointer tupleid, - EState *estate, bool noDupErr, bool *specConflict, - List *arbiterIndexes); +extern List *ExecInsertIndexTuples(TupleTableSlot *slot, EState *estate, bool noDupErr, + bool *specConflict, List *arbiterIndexes); extern bool ExecCheckIndexConstraints(TupleTableSlot *slot, EState *estate, ItemPointer conflictTid, List *arbiterIndexes); extern void check_exclusion_constraint(Relation heap, Relation index, diff --git a/src/include/executor/tuptable.h b/src/include/executor/tuptable.h index fb39c3ef27..52576dbed2 100644 --- a/src/include/executor/tuptable.h +++ b/src/include/executor/tuptable.h @@ -142,6 +142,7 @@ typedef struct TupleTableSlot Oid tts_tableOid; /* XXX describe */ Oid tts_tupleOid; /* XXX describe */ uint32 tts_speculativeToken; /* XXX describe */ + bool tts_specConflict; /* XXX describe */ struct SlotTableAmRoutine *tts_slottableam; /* table AM */ void *tts_storage; /* table AM's opaque space */ } TupleTableSlot; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index da7f52cab0..1c6778b3b8 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -555,7 +555,7 @@ typedef struct EState * remember if the tuple has been returned already. Arrays are of size * list_length(es_range_table) and are indexed by scan node scanrelid - 1. */ - HeapTuple *es_epqTuple; /* array of EPQ substitute tuples */ + TableTuple *es_epqTuple; /* array of EPQ substitute tuples */ bool *es_epqTupleSet; /* true if EPQ tuple is provided */ bool *es_epqScanDone; /* true if EPQ tuple has been fetched */ @@ -2107,7 +2107,7 @@ typedef struct HashInstrumentation int nbatch; /* number of batches at end of execution */ int nbatch_original; /* planned number of batches */ size_t space_peak; /* speak memory usage in bytes */ -} HashInstrumentation; +} HashInstrumentation; /* ---------------- * Shared memory container for per-worker hash information @@ -2117,7 +2117,7 @@ typedef struct SharedHashInfo { int num_workers; HashInstrumentation hinstrument[FLEXIBLE_ARRAY_MEMBER]; -} SharedHashInfo; +} SharedHashInfo; /* ---------------- * HashState information @@ -2178,7 +2178,7 @@ typedef struct LockRowsState PlanState ps; /* its first field is NodeTag */ List *lr_arowMarks; /* List of ExecAuxRowMarks */ EPQState lr_epqstate; /* for evaluating EvalPlanQual rechecks */ - HeapTuple *lr_curtuples; /* locked tuples (one entry per RT entry) */ + TableTuple *lr_curtuples; /* locked tuples (one entry per RT entry) */ int lr_ntables; /* length of lr_curtuples[] array */ } LockRowsState; -- 2.16.1.windows.4