| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Lift line-length limit for pg_service.conf |
| Date: | 2020-09-22 20:07:10 |
| Message-ID: | 1310612.1600805230@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> [ 0001-Refactor-pg_service.conf-and-pg_restore-TOC-file-par.patch ]
I reviewed this and noticed that you'd missed adding resetStringInfo
calls in some code paths, which made me realize that while
pg_get_line_append() is great for its original customer in hba.c,
it kinda sucks for most other callers. Having to remember to do
resetStringInfo in every path through a loop is too error-prone,
and it's unnecessary. So I made another subroutine that just adds
that step, and updated the existing callers that could use it.
Pushed with that correction.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-09-22 20:11:01 | Re: Improper use about DatumGetInt32 |
| Previous Message | Robert Haas | 2020-09-22 20:02:46 | Re: Improper use about DatumGetInt32 |