| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__. |
| Date: | 2015-03-25 23:11:06 |
| Message-ID: | 14247.1427325066@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Add macros wrapping all usage of gcc's __attribute__.
I noticed that this commit attached pg_attribute_noreturn not only
to the extern declarations, but to some actual function definitions.
I think this is a bad idea, because it's going to look like heck after
pgindent gets through with it. Do we actually need decoration on the
function definitions?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-03-26 00:51:23 | Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1() |
| Previous Message | Tom Lane | 2015-03-25 23:05:45 | pgsql: Add an ASSERT statement in plpgsql. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-03-26 00:43:58 | Re: Error with index on unlogged table |
| Previous Message | Tom Lane | 2015-03-25 23:08:16 | Re: proposal: plpgsql - Assert statement |