Re: Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: nagata(at)sraoss(dot)co(dot)jp
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()
Date: 2017-07-28 03:03:01
Message-ID: 20170728.120301.1977408759697450997.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg().
> This says "Compute ID and segment from an XLogRecPtr", but these
> macros compute only segment numbers. I think "Compute a segment number
> from an XLogRecPtr" is correct.
>
> The definition of these macros were modified by the following commit,
> but the comment were not.
>
> commit dfda6ebaec6763090fb78b458a979b558c50b39b
> Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
> Date: Sun Jun 24 18:06:38 2012 +0300

Thanks for the patch. Looks good to me. I will commit/push into all
supported branches if there's no objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2017-07-28 03:23:54 Re: On Complex Source Code Reading Strategy
Previous Message Tom Lane 2017-07-28 02:48:35 PL_stashcache, or, what's our minimum Perl version?