| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is it time to kill support for very old servers? |
| Date: | 2017-10-11 01:46:44 |
| Message-ID: | 20171011014644.swi5edu3w75tmjea@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-10-11 10:40:11 +0900, Michael Paquier wrote:
> >> + if (conn->forced_protocol_version != NULL)
> >> + {
> >> + conn->pversion = atoi(conn->forced_protocol_version);
> >> + }
> >> This should check for strlen > 0 as well.
> >
> > Why? Note that we don't do elsehwere in fe-connect.c.
>
> Because it seems to me that the default value of the parameter should
> be an empty string instead of D. Feels more consistent with the
> others.
I'm not following. The "D" is in the 'dispchar' field, not the value
field, no? The default value is NULL?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-11 01:51:56 | Re: Is it time to kill support for very old servers? |
| Previous Message | Michael Paquier | 2017-10-11 01:40:11 | Re: Is it time to kill support for very old servers? |