| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: PATCH: Unlogged tables re-initialization tests |
| Date: | 2018-03-11 09:11:49 |
| Message-ID: | 20180311091149.GB5399@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote:
> This seems like a useful test.
>
> On 3/5/18 12:35, David Steele wrote:
> > +mkdir($tablespaceDir)
> > + or die "unable to mkdir \"$tablespaceDir\"";
>
> Use BAIL_OUT instead of die in tests.
Would it be better to make this practice more uniform? From the code of
the tests:
$ git grep die -- */t/*.pl | wc -l
50
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2018-03-11 09:23:24 | Re: MCV lists for highly skewed distributions |
| Previous Message | Dean Rasheed | 2018-03-11 09:09:22 | Re: Bogus use of canonicalize_qual |