| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: crash with sql language partition support function |
| Date: | 2018-04-13 10:20:40 |
| Message-ID: | 20180413102040.fkgtszutcbf5hfui@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Langote wrote:
> On 2018/04/13 6:58, Alvaro Herrera wrote:
> > After going over your patch, I think you went slightly overboard here.
> > Or maybe not, but this patch is so large that it's hard to form an
> > opinion about it.
>
> It's mostly code movement, but there are some other changes as well as
> described below.
Hmm can you please split out the code changes into a separate patch? I
can commit the code movement quickly, but the other stuff requres more
creful review.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2018-04-13 10:34:55 | Re: pgsql: New files for MERGE |
| Previous Message | Amit Langote | 2018-04-13 10:14:09 | Re: crash with sql language partition support function |