| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use durable_unlink for .ready and .done files for WAL segment removal |
| Date: | 2018-09-28 03:40:26 |
| Message-ID: | 20180928034026.emkeqslnidihwber@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-09-28 12:28:27 +0900, Michael Paquier wrote:
> While reviewing the archiving code, I have bumped into the fact that
> XLogArchiveCleanup() thinks that it is safe to do only a plain unlink()
> for .ready and .done files when removing a past segment. I don't think
> that it is a smart move, as on a subsequent crash we may still see
> those, but the related segment would have gone away. This is not really
> a problem for .done files, but it could confuse the archiver to see some
> .ready files about things that have already gone away.
Isn't that window fundamentally there anyway?
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-09-28 03:54:10 | Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal) |
| Previous Message | Michael Paquier | 2018-09-28 03:28:27 | Use durable_unlink for .ready and .done files for WAL segment removal |