| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Update InsertPgAttributeTuple comment to match new signature |
| Date: | 2020-06-23 05:31:05 |
| Message-ID: | 20200623053105.GK50978@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 22, 2020 at 04:27:18PM +0200, Daniel Gustafsson wrote:
> The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
> reality as attoptions isn't always initialized to NULL. The attached removes
> mention of attoptions, and updates the list of always-NULL attributes to match
> what the code does (the git history didn't provide rationale for why they were
> omitted so it seemed like an oversight).
Looks right to me, good catch. I'll apply that tomorrow my time
except if there are any objections in-between.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Sewell | 2020-06-23 06:01:51 | Re: Threading in BGWorkers (!) |
| Previous Message | Amit Kapila | 2020-06-23 05:28:18 | Re: Resetting spilled txn statistics in pg_stat_replication |