| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration |
| Date: | 2020-09-24 07:12:53 |
| Message-ID: | 20200924071253.GR28585@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 23, 2020 at 08:11:59AM +0200, Peter Eisentraut wrote:
> This patch mixes up unsigned int and uint32 in random ways. The variable is
> uint32, but the format is %u and the max constant is UINT_MAX.
>
> I think just use unsigned int as the variable type. There is no need to use
> the bit-exact types. Note that the argument of alarm() is of type unsigned
> int.
Makes sense, thanks.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgtest-fix-range-v6.patch | text/x-diff | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-09-24 07:24:19 | Re: Online checksums patch - once again |
| Previous Message | Bharath Rupireddy | 2020-09-24 07:04:41 | Re: Parallel copy |