| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add |
| Date: | 2020-10-12 01:16:46 |
| Message-ID: | 20201012011646.GD2346@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Oct 11, 2020 at 08:35:13PM +0200, Christoph Berg wrote:
> Re: Tom Lane
>> Hmm, I'd argue for a back-patch. The issue of modern compilers
>> warning about the incorrect code will apply to all supported branches.
>> Moreover, even if we don't use these code paths today, who's to say
>> that someone won't back-patch a bug fix that requires them? I do not
>> think it's unreasonable to expect these functions to work well in
>> all branches that have them.
>
> Or remove them. (But fixing seems better.)
The patch is not that invasive, so just fixing back-branches sounds
like a good idea to me. My 2c.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2020-10-12 04:38:47 | pgsql: For ppc gcc, implement 64-bit compare_exchange and fetch_add wit |
| Previous Message | Christoph Berg | 2020-10-11 18:35:13 | Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2020-10-12 01:20:35 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Michael Paquier | 2020-10-12 01:12:12 | Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump. |