| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add some const decorations to prototypes |
| Date: | 2017-10-31 14:56:07 |
| Message-ID: | 20359.1509461767@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Here is a patch that adds const decorations to many char * arguments in
> functions. It should have no impact otherwise; there are very few code
> changes caused by it.
+1 in general ...
> Some functions have a strtol()-like behavior
> where they take in a const char * and return a pointer into that as
> another argument. In those cases, I added a cast or two.
... but I'm not sure that it's an improvement in cases where you have to
cast away the const somewhere else. I realize that strtol has an ancient
pedigree, but I do not think it's very good design.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-10-31 15:00:38 | Re: Fix dumping pre-10 DBs by pg_dump10 if table "name" exists |
| Previous Message | Peter Eisentraut | 2017-10-31 14:46:49 | Add some const decorations to prototypes |