| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, postgres(at)piotr-stefaniak(dot)me, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_bsd_indent and -Wimplicit-fallthrough |
| Date: | 2020-05-16 15:56:28 |
| Message-ID: | 23978.1589644588@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 15 May 2020, at 08:28, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>> The patch looks good to me. It looks like we already have custom
>>> patches, so +1 to applying it.
>> Shouldn't we try and propose it to upstream first to minimize our diff?
> Good point, adding Piotr.
In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-16 15:58:41 | Re: pgindent && weirdness |
| Previous Message | Tomas Vondra | 2020-05-16 14:56:09 | Re: POC: GROUP BY optimization |