| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: spgist rangetypes compiler warning (gcc 7.2.0) |
| Date: | 2017-11-18 21:40:13 |
| Message-ID: | 25711.1511041213@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> while compiling on gcc 7.2.0 (on ARM), I got this warning:
> rangetypes_spgist.c: In function 'spg_range_quad_inner_consistent':
> rangetypes_spgist.c:559:29: warning: comparison between pointer and
> zero character constant [-Wpointer-compare]
> if (in->traversalValue != (Datum) 0)
> ^~
Huh. I wonder why 7.2.1 on Fedora isn't producing that warning.
> I believe we should simply treat the traversalValue as pointer, and
> change the condition to
> if (in->traversalValue)
Agreed, especially since it's done like that in spgscan.c and
geo_spgist.c.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-11-18 21:40:58 | Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means |
| Previous Message | Tom Lane | 2017-11-18 21:31:16 | Re: [HACKERS] Repetitive code in RI triggers |