| From: | Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: merge psql ef/ev sf/sv handling functions |
| Date: | 2017-07-18 12:10:24 |
| Message-ID: | 3fcca87aa4eacdc5981a5b219530dc1f@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-03-31 21:04, Fabien COELHO wrote:
> Hello,
>
> While reviewing Corey's \if patch, I complained that there was some
> amount of copy-paste in "psql/command.c".
>
> Here is an attempt at merging some functions which removes 160 lines of
> code.
Hello,
I was looking through your patch. It seems good, the of the functions
was very similar.
I have a question for you. What was the reason to replace
"printfPQExpBuffer" by "resetPQExpBuffer" and "appendPQExpBufferStr"?
Thank you for attention!
--
------
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Chernyshov | 2017-07-18 12:18:25 | [PATCH] Add citext_pattern_ops to citext contrib module |
| Previous Message | Andres Freund | 2017-07-18 12:04:09 | Re: segfault in HEAD when too many nested functions call |