| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_control read error message |
| Date: | 2018-05-18 12:54:47 |
| Message-ID: | 4fa3b8c2-f607-01af-a83f-9e596e5e9516@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18/05/18 14:32, Magnus Hagander wrote:
> If pg_control is for some reason empty, we give an error messagfe like:
>
> 2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
> file: Success
>
> Which is, uh, wrong -- it's definitely not successful.
>
> Obviously this is a state where the user is fairly screwed anyway, but we
> should give a better message.
>
> Attached is a patch that does this. Reasonable?
Looks good to me.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2018-05-18 12:56:42 | Re: Postgres, fsync, and OSs (specifically linux) |
| Previous Message | John Naylor | 2018-05-18 11:49:15 | Re: master fails to build on Windows |