| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Division in dynahash.c due to HASH_FFACTOR |
| Date: | 2020-09-19 01:30:56 |
| Message-ID: | 603568.1600479056@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> ISTM that getting rid of the division obviates the concern that the
> nentries condition is too expensive,
Also, we could make it slightly cheaper yet, by changing the condition
to
hctl->freeList[0].nentries > (long) (hctl->max_bucket)
ie drop the +1. I'd argue that this is actually a more faithful
rendition of the previous condition, since what we had before was
basically
hctl->freeList[0].nentries >= (long) (hctl->max_bucket + 1)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-19 01:48:58 | Re: pg_logging_init() can return ENOTTY with TAP tests |
| Previous Message | Tom Lane | 2020-09-19 01:11:46 | Re: Division in dynahash.c due to HASH_FFACTOR |