| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits |
| Date: | 2020-07-01 09:38:59 |
| Message-ID: | 74D1F1CD-40A6-42C8-8FD8-65AB31D6D067@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This patch incurs a compiler warning, which probably is quite simple to fix:
heapam.c: In function ‘heap_multi_insert’:
heapam.c:2349:4: error: ‘recptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
visibilitymap_set(relation, BufferGetBlockNumber(buffer), buffer,
^
heapam.c:2136:14: note: ‘recptr’ was declared here
XLogRecPtr recptr;
^
Please fix and submit a new version, I'm marking the entry Waiting on Author in
the meantime.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-07-01 09:45:06 | Re: Towards easier AMs: Cleaning up inappropriate use of name "relkind" |
| Previous Message | Bharath Rupireddy | 2020-07-01 09:33:06 | Re: [PATCH] Performance Improvement For Copy From Binary Files |