| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused variable scanned_tuples in LVRelStats |
| Date: | 2017-08-03 18:01:46 |
| Message-ID: | CA+TgmoYydRzM_V+363s1r2jMt9RRCQ5RoDz5fHt+m1MgtswRDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> So we can remove scanned_tuples from LVRelStats struct and change the
> variable name num_tuples to scanned_tuples. Attached updated patch.
On second thought, I think we should just leave this alone.
scanned_tuples is closely tied to tupcount_pages, so it's a little
confusing to pull one out and not the other. And we can't pull
tupcount_pages out of LVRelStats because lazy_cleanup_index needs it.
The current situation isn't doing any harm, so I'm not seeing much
point in changing it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-08-03 18:14:01 | Re: Tightly packing expressions |
| Previous Message | Douglas Doole | 2017-08-03 18:01:06 | Tightly packing expressions |