| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Partition-wise aggregation/grouping |
| Date: | 2018-03-02 18:42:35 |
| Message-ID: | CA+TgmoZNa=5fUsy=4KpV4WUnti90Rq9wahMs25or4zDv2m7+7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 1, 2018 at 4:52 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> This is not a full review, but I'm out of time for right now.
Another thing I see here now is that create_grouping_paths() and
create_child_grouping_paths() are extremely similar. Isn't there some
way we can refactor things so that we can reuse the code instead of
duplicating it?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuzmenkov | 2018-03-02 18:47:27 | Re: IndexJoin memory problem using spgist and boxes |
| Previous Message | Tom Lane | 2018-03-02 18:29:59 | Re: [HACKERS] log_destination=file |