| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Alexander Kumenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: Improve bitmap costing for lossy pages |
| Date: | 2017-10-06 13:06:08 |
| Message-ID: | CA+TgmoaYBUSf2iuJBNXM8Tm-=cTAUV112EziXp6iOG2Z9MC--w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 6, 2017 at 2:12 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>> The performance results look good, but that's a slightly different
>> thing from whether the estimate is accurate.
>>
>> + nbuckets = tbm_calculate_entires(maxbytes);
>>
>> entires?
>
> changed to
> + tbm->maxentries = (int) tbm_calculate_entires(maxbytes);
My point was not that you should add a cast, but that you wrote
"entires" rather than "entries".
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2017-10-06 13:08:13 | Re: parallel worker (PID ) exited with exit code 1 |
| Previous Message | Michael Paquier | 2017-10-06 13:02:48 | Re: parallel worker (PID ) exited with exit code 1 |