| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Kelly Min <myzhmin(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Comments related to " buffer descriptors“ cache line size" |
| Date: | 2020-09-04 20:26:06 |
| Message-ID: | CA+hUKG+N3fUcUy_VbBj938M2zjTn_ir6rCA9YR2DN_nY5NMrgQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 5, 2020 at 5:28 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Sep 4, 2020 at 11:31:55PM +0800, Kelly Min wrote:
> > I found a comment error in buffer descriptors comment. The cache line size is
> > 64 bytes, not 64 bits
>
> Thanks, fix applied to all active branches.
I find it a bit strange that our PG_CACHE_LINE_SIZE macro is defined
to be 128. Whether that exaggerated number (unless you're on POWER,
where it's true) makes sense depends on what your goals are, as this
usage of hard-coded 64 shows...
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-09-04 20:28:49 | Re: A micro-optimisation for walkdir() |
| Previous Message | Bruce Momjian | 2020-09-04 20:12:24 | Re: BUG #16419: wrong parsing BC year in to_date() function |