| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Division in dynahash.c due to HASH_FFACTOR |
| Date: | 2020-09-18 23:56:06 |
| Message-ID: | CA+hUKGJS6_d4dxmLs6xw8osu5bB1P8Dx9qqj1j4yk-sRT68cDw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 15, 2020 at 9:56 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > I looked over the patch and the only thing I saw was that we might
> > also want to remove the following line:
> >
> > #define DEF_FFACTOR 1 /* default fill factor */
>
> Right, thanks. Fixed in the attached.
Pushed. Thanks Jakub, everyone.
Separately, we really should tidy up the int/long/uint32/size_t
confusion in this module. I know we have K&R C-era long-itude in
numerous other modules, but this one is a little more egregious in its
data type mixing.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-09-19 00:18:16 | Re: factorial function/phase out postfix operators? |
| Previous Message | Bruce Momjian | 2020-09-18 23:32:01 | Re: pg_service.conf file with unknown parameters |