| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Shoaib Lari <slari(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix Error Message for allocate_recordbuf() Failure |
| Date: | 2016-09-21 01:25:24 |
| Message-ID: | CAB7nPqQR5qADVSfNSHhcqzoMnkQnmYbkrdsGV1MyNMVx6SEtSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | kèo chấp bóng |
On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> For what it's worth, I think it's fine. Good error messages are a useful thing.
>
> More generally, I think the whole patch looks good and should be committed.
Hm. I'd think that it is still more portable to just issue a WARNING
message in palloc_extended() when MCXT_ALLOC_NO_OOM then. Other code
paths could benefit from that as well, and the patch proposed does
nothing for the other places calling it. I am fine to write a patch
for this purpose if you agree on that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2016-09-21 02:23:02 | Re: New SQL counter statistics view (pg_stat_sql) |
| Previous Message | Peter Eisentraut | 2016-09-21 00:59:37 | Re: Exclude schema during pg_restore |