| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why SyncRepWakeQueue is not static? |
| Date: | 2015-03-25 03:54:48 |
| Message-ID: | CAB7nPqRPSk_uoHTJgC3iwTZEexTZM0vd4ygRrxke+Vs+jwQdxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2015 at 12:13 PM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> SyncRepWakeQueue (src/backend/replication/syncrep.c) is not used
> anywhere except in the file. If there's no good reason for it, I think
> it should be declared as a static function. Included patch does so.
That's indeed contradictory with what is written in syncrep.h, the
function is not called from other places.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-03-25 03:56:07 | Re: parallel mode and parallel contexts |
| Previous Message | David Steele | 2015-03-25 03:23:10 | Re: Auditing extension for PostgreSQL (Take 2) |