| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c) |
| Date: | 2020-09-11 17:10:31 |
| Message-ID: | CAEudQArLccmAYgJ7i9oZynE3kejteK-OEfH7EcnTWQPFYV5SHQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex., 11 de set. de 2020 às 14:01, Alvaro Herrera <
alvherre(at)2ndquadrant(dot)com> escreveu:
> On 2020-Sep-11, Ranier Vilela wrote:
>
> > Hi,
> >
> > read_binary_file seems a bit complicated when we want to read the rest of
> > the file (-1 for bytes_to_read).
>
> This code was very recently rewritten in 96d1f423f95d, and I doubt that
> taking out half the algorithm without studying how it got that way is a
> great idea.
>
Works with all regress tests (199, same as the HEAD with msvc 2019 64 bits
except partition_prune)
Works with pgbench (pgbench -U postgres -c 50 -j 2 -t 10000 example)
And works with local installation, without adverse effects, for now.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-09-11 17:41:01 | Re: [patch] _bt_binsrch* improvements - equal-prefix-skip binary search |
| Previous Message | Alvaro Herrera | 2020-09-11 17:01:04 | Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c) |