| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logtape.c stats don't account for unused "prefetched" block numbers |
| Date: | 2020-09-14 22:39:08 |
| Message-ID: | CAH2-Wzkyt-kOOsb2XnQk6w_cZOYW8XCykAysAVg6iJDXqZ4A5Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 14, 2020 at 3:24 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> I don't understand this patch. Or maybe I should say I don't understand
> the code you're patching. Why isn't the correct answer *always*
> nBlocksWritten? The comment in LogicalTapeSet says:
I think that they are an exact match in practice (i.e. nBlocksWritten
== nBlocksAllocated), given when and how we call
LogicalTapeSetBlocks().
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-09-14 22:54:48 | Re: logtape.c stats don't account for unused "prefetched" block numbers |
| Previous Message | Tom Lane | 2020-09-14 22:28:09 | Re: pg_restore causing deadlocks on partitioned tables |