| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup - Removal of unused function parameter from CopyReadBinaryAttribute |
| Date: | 2020-06-18 14:09:41 |
| Message-ID: | CALj2ACUv1+DpKEuRAryTMPjqOidjgGFGA4QQB_ZYFuJef8ap_Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2020 at 7:01 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> While checking copy from code I found that the function parameter
> column_no is not used in CopyReadBinaryAttribute. I felt this could be
> removed.
> Attached patch contains the changes for the same.
> Thoughts?
>
I don't see any problem in removing this extra parameter.
However another thought, can it be used to report a bit meaningful
error for field size < 0 check?
if (fld_size < 0)
ereport(ERROR,
(errcode(ERRCODE_BAD_COPY_FILE_FORMAT),
errmsg("invalid field size for column %d", column_no)));
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Winfield, Steven | 2020-06-18 14:22:10 | Mark btree_gist functions as PARALLEL SAFE |
| Previous Message | Justin Pryzby | 2020-06-18 13:45:14 | Re: Missing HashAgg EXPLAIN ANALYZE details for parallel plans |