| From: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Tels <nospam-pg-abuse(at)bloodgate(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [WIP PATCH] Index scan offset optimisation using visibility map |
| Date: | 2018-03-12 09:01:29 |
| Message-ID: | CANtu0ohBE_JmQ43YuPiPBrkasgwF6M3rGzsY91g2UiGtosm9Hw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
> Sorry, seems like I've incorrectly expressed what I wanted to say.
> I mean this Assert() can be checked before loop, not on every loop cycle.
Yes, I understood it. Condition should be checked every cycle - at least it
is done this way for index only scan:
https://github.com/postgres/postgres/blob/master/src/backend/executor/nodeIndexonlyscan.c#L234
But since original index scan do not contains such check (probably due ot
https://github.com/postgres/postgres/blob/master/src/backend/executor/nodeIndexscan.c#L552)
- I think it could be removed.
Michail.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ildar Musin | 2018-03-12 09:26:15 | Re: Failed to request an autovacuum work-item in silence |
| Previous Message | Konstantin Knizhnik | 2018-03-12 08:55:39 | Re: All Taxi Services need Index Clustered Heap Append |