| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a |
| Date: | 2020-09-15 08:46:56 |
| Message-ID: | CAOBaU_bmc1Ck4VygNxZ81HrEZ1VTkC-8BWYz0MhJOtUU46v-aQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 15, 2020 at 4:48 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Sep 10, 2020 at 02:31:32PM +0200, Daniel Gustafsson wrote:
> > Given how unintrusive this optimization is, +1 from me to go ahead with this
> > patch. pg_dump tests pass. Personally I would've updated the nearby comments
> > to reflect why the check for dataOnly is there, but MMV there. I'm moving this
> > patch to Ready for Committer.
>
> We need two comments here. I would suggest something like:
> "Skip default/check for a data-only dump, as this is only needed for
> dumps of the table schema."
>
> Better wording is of course welcome.
FWIW I'm fine with those news comments!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2020-09-15 09:03:14 | Re: [patch] _bt_binsrch* improvements - equal-prefix-skip binary search |
| Previous Message | David Rowley | 2020-09-15 08:34:21 | Re: Use incremental sort paths for window functions |