| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimise default partition scanning while adding new partition |
| Date: | 2017-09-14 08:03:52 |
| Message-ID: | CAOgcT0NPqYadGwqc8opkUZNWiByk+ooK29h0pYk2eL4niMZtyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Amit for reviewing.
Patch looks fine to me. By the way, why don't we just say "Can we skip
> scanning part_rel?" in the comment before the newly added call to
> PartConstraintImpliedByRelConstraint()? We don't need to repeat the
> explanation of what it does at the every place we call it.
>
I have changed the comment.
PFA.
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Check-default-partitition-child-validation-scan-is.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2017-09-14 08:24:51 | Re: Patches that don't apply or don't compile: 2017-09-12 |
| Previous Message | Dean Rasheed | 2017-09-14 08:01:46 | Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b |