| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix confusion on the padding of GIDs in on commit and abort reco |
| Date: | 2018-04-17 20:11:10 |
| Message-ID: | E1f8WwY-0006Qs-27@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix confusion on the padding of GIDs in on commit and abort records.
Review of commit 1eb6d652: It's pointless to add padding to the GID fields,
when the code that follows assumes that there is no alignment, and uses
memcpy(). Remove the pointless padding.
Update comments to note the new fields in the WAL records.
Reviewed-by: Michael Paquier
Discussion: /message-id/33b787bf-dc20-1161-54e9-3f3b607bf59d%40iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cf5a1890592bfa2f45d306789533efba97496233
Modified Files
--------------
src/backend/access/rmgrdesc/xactdesc.c | 16 ++++++++--------
src/backend/access/transam/twophase.c | 2 ++
src/backend/access/transam/xact.c | 24 ++----------------------
src/include/access/xact.h | 5 ++++-
src/include/access/xlog_internal.h | 2 +-
5 files changed, 17 insertions(+), 32 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2018-04-17 20:15:08 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Previous Message | Alvaro Herrera | 2018-04-17 19:26:49 | Re: pgsql: Support partition pruning at execution time |