| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposed patch for key managment |
| Date: | 2020-12-07 02:03:30 |
| Message-ID: | X82Nclm24KrB0S9I@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 05, 2020 at 10:42:05AM -0500, Bruce Momjian wrote:
> On Sat, Dec 5, 2020 at 09:54:33PM +0900, Michael Paquier wrote:
>> On Fri, Dec 04, 2020 at 10:52:29PM -0500, Bruce Momjian wrote:
>>> if (state->evpctx == NULL)
>>> {
>>> - explicit_bzero(state, sizeof(pg_cryptohash_state));
>>> - explicit_bzero(ctx, sizeof(pg_cryptohash_ctx));
>>> #ifndef FRONTEND
>>> ereport(ERROR,
>>> (errcode(ERRCODE_OUT_OF_MEMORY),
>>
>> And this original position is IMO more correct.
>
> Do we even need them?
That's the intention to clean up things in a consistent way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-12-07 02:22:01 | Re: A few new options for CHECKPOINT |
| Previous Message | Zhihong Yu | 2020-12-07 01:25:49 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |