| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "Rady, Doug" <radydoug(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
| Date: | 2018-03-01 10:30:39 |
| Message-ID: | alpine.DEB.2.20.1803011121300.7903@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> -#ifdef HAVE_SYS_SELECT_H
>> +#ifdef PGBENCH_USE_SELECT /* force use of select(2)? */
>> +#undef HAVE_PPOLL
>> +#endif
>> +#ifdef HAVE_PPOLL
>> +#include <poll.h>
>> +#elif defined(HAVE_SYS_SELECT_H)
>> +#define POLL_USING_SELECT
>
> (random thing noticed while going through patches)
>
> It strikes me as a bad idea to undefine configure selected
> symbols. Postgres header might rely on them. It also strikes me as
> entirely unnecessary here.
Yes, I though about this one but let it pass. Indeed, it would be
sufficient to not load "poll.h" when select is forced, without undefining
the configure setting.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2018-03-01 10:34:26 | Re: [HACKERS] Partition-wise aggregation/grouping |
| Previous Message | Andres Freund | 2018-03-01 10:28:54 | Re: [HACKERS] taking stdbool.h into use |