| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, khuddleston(at)pivotal(dot)io |
| Subject: | Re: Making "COPY partitioned_table FROM" faster |
| Date: | 2018-07-30 08:33:36 |
| Message-ID: | d6546c1a-ce05-c589-f2f0-b5d9c964bee3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Two more thoughts:
- Add some tests. The if (nBufferedTuples > 0) that flushes the tuples
when the partition changes is not currently exercised.
- With proute becoming a function-level variable,
cstate->partition_tuple_routing is obsolete and could be removed. (No
point in saving this in cstate if it's only used in one function anyway.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-30 08:38:04 | Re: Making "COPY partitioned_table FROM" faster |
| Previous Message | Amit Langote | 2018-07-30 08:26:52 | Re: Speeding up INSERTs and UPDATEs to partitioned tables |