| From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
|---|---|
| To: | "Simon Muller" <samullers(at)gmail(dot)com> |
| Cc: | "Cynthia Shang" <cynthia(dot)shang(at)crunchydata(dot)com>,pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow COPY's 'text' format to output a header |
| Date: | 2018-08-02 12:11:44 |
| Message-ID: | f1b42751-659f-43fc-8747-b9c8932d196a@manitou-mail.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Muller wrote:
> I changed the error type and message for consistency with other similar
> errors in that file. Whenever options are combined that are incompatible,
> it looks like the convention is for a ERRCODE_SYNTAX_ERROR to be thrown.
That makes sense, thanks for elaborating, although there are also
a fair number of ERRCODE_FEATURE_NOT_SUPPORTED in copy.c
that are raised on forbidden/nonsensical combination of features,
so the consistency argument could work both ways.
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-08-02 13:05:33 | Re: [HACKERS] Restricting maximum keep segments by repslots |
| Previous Message | Daniel Verite | 2018-08-02 11:37:17 | Re: [HACKERS] Can ICU be used for a database's default sort order? |