| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Question about WalSndWriteData |
| Date: | 2018-03-21 01:50:49 |
| Message-ID: | fbac36bc-d0ab-e1b4-f798-663040c0b604@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/16/18 12:08, Konstantin Knizhnik wrote:
> pq_putmessage_noblock copies data from ctx->out buffer to libpq buffers.
> After it we write timestamp to ctx->out buffer.
> And comments says that we should do it "as late as possible".
> But this timestamp is not included in the copy data packet which is
> already copied to libpq connection buffer.
There is a pq_flush_if_writable() right after this that will write out
the rest of ctx->out.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kefan Yang | 2018-03-21 02:01:27 | Re: [GSoC 2018] Proposal Draft |
| Previous Message | Andres Freund | 2018-03-21 00:50:08 | Re: JIT compiling with LLVM v12.2 |