| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Timing-sensitive case in src/test/recovery TAP tests |
| Date: | 2017-06-26 18:44:02 |
| Message-ID: | 14061.1498502642@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Mon, Jun 26, 2017 at 12:12 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>> I'm not sure I understand this.
> The patch attached may explain that better. Your patch added 3 poll
> phases. I think that a 4th is needed. At the same time I have found
> cleaner to put the poll calls into a small wrapper.
Looks good as far as it goes, but I wonder whether any of the other
get_slot_xmins calls need polling too. Don't feel a need to add such
calls until someone exhibits a failure there, but I won't be very
surprised if someone does.
Anyway, pushed this patch with minor editing. Thanks!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-26 19:15:37 | Re: Reducing pg_ctl's reaction time |
| Previous Message | Simon Riggs | 2017-06-26 18:41:29 | Re: Another reason why the recovery tests take a long time |