| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Timing-sensitive case in src/test/recovery TAP tests |
| Date: | 2017-06-26 23:36:51 |
| Message-ID: | CAB7nPqTuFCTyDJCNpYZ-MtHhBasjYOzDYkHcn9S1PQBc5MdHtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 27, 2017 at 3:44 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Looks good as far as it goes, but I wonder whether any of the other
> get_slot_xmins calls need polling too. Don't feel a need to add such
> calls until someone exhibits a failure there, but I won't be very
> surprised if someone does.
I got the same thought, wondering as well if get_slot_xmins should be
renamed check_slot_xmins with the is() tests moved inside it as well.
Not sure if that's worth the API ugliness though.
> Anyway, pushed this patch with minor editing. Thanks!
Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-06-27 00:20:23 | Re: Causal reads take II |
| Previous Message | Tom Lane | 2017-06-26 22:13:56 | Re: Reducing pg_ctl's reaction time |