| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Microoptimization of Bitmapset usage in postgres_fdw |
| Date: | 2018-06-14 20:14:54 |
| Message-ID: | FD2C3227-45D8-493A-AB5A-2BA04733191B@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the updated patch set.
On 6/14/18, 2:34 PM, "Daniel Gustafsson" <daniel(at)yesql(dot)se> wrote:
>> 2) BuildRelationExtStatistics() in extended_stats.c.
>>
>> /* check allowed number of dimensions */
>> Assert(bms_num_members(stat->columns) >= 2 &&
>> bms_num_members(stat->columns) <= STATS_MAX_DIMENSIONS);
>
> Since this usage is in an assertion I don’t see the value in changing it as the
> current programming is more optimized for readability.
Agreed. I hesitated to even point this one out.
I'll go ahead and mark this as Ready for Committer.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-14 20:17:28 | Re: Portability concerns over pq_sendbyte? |
| Previous Message | Tom Lane | 2018-06-14 20:10:42 | Re: Shared access methods? |